-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] [File data visualizer] Removing scss files #178314
Changes from 3 commits
3360118
5c61bbf
d78c042
64d7844
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
@import 'common/components/index'; | ||
@import 'file_data_visualizer/index'; |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -7,6 +7,7 @@ | |||||||||||
|
||||||||||||
import { FormattedMessage } from '@kbn/i18n-react'; | ||||||||||||
import React, { Component } from 'react'; | ||||||||||||
import { euiThemeVars } from '@kbn/ui-theme'; | ||||||||||||
|
||||||||||||
import { EuiAccordion, EuiPagination } from '@elastic/eui'; | ||||||||||||
|
||||||||||||
|
@@ -56,11 +57,11 @@ export class Failures extends Component<Props, State> { | |||||||||||
} | ||||||||||||
paddingSize="m" | ||||||||||||
> | ||||||||||||
<div className="failure-list"> | ||||||||||||
<div css={{ maxHeight: '200px', overflowY: 'auto' }}> | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question as above. Reformat for Emotion?
Suggested change
|
||||||||||||
{this._renderPaginationControl()} | ||||||||||||
{this.props.failedDocs.slice(startIndex, endIndex).map(({ item, reason, doc }) => ( | ||||||||||||
<div key={item}> | ||||||||||||
<div className="error-message"> | ||||||||||||
<div css={{ color: euiThemeVars.euiColorDanger }}> | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question as above. Reformat for Emotion?
Suggested change
|
||||||||||||
{item}: {reason} | ||||||||||||
</div> | ||||||||||||
<div>{JSON.stringify(doc)}</div> | ||||||||||||
|
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,7 +84,7 @@ export const ResultsView: FC<Props> = ({ | |
</EuiFlexGroup> | ||
|
||
<EuiSpacer size="m" /> | ||
<div className="results"> | ||
<div> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With the removal of this |
||
<EuiPanel data-test-subj="dataVisualizerFileFileContentPanel" hasShadow={false} hasBorder> | ||
<FileContents | ||
data={data} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be reformatted for Emotion? Something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. I'm not sure I understand the advantage of using a template literal over an object for these styles?
Looking at the generated css, it's basically the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, technically it'll result in the same outcome. I was just thinking in terms of consistency in the writing of styles. That said, it's not a deal-breaker by any means. If ya'll prefer to write your styles in a mix of formats, I'll defer to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree consistency is better. I've switched away from using template literals in this whole PR in favour of plain objects, which read better to me.
Updated in 584db08