Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Quote automatically for source/policies/fields with special chars #174676

Merged
merged 6 commits into from
Jan 12, 2024
Merged

[ES|QL] Quote automatically for source/policies/fields with special chars #174676

merged 6 commits into from
Jan 12, 2024

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jan 11, 2024

Summary

Add support for automatic quoting on autocomplete. Added tests.

esql_quote_special_fields

Checklist

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana v8.13.0 labels Jan 11, 2024
@dej611
Copy link
Contributor Author

dej611 commented Jan 11, 2024

/ci

@dej611
Copy link
Contributor Author

dej611 commented Jan 11, 2024

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #14 / AssigneesFilterPopover calls onSelectionChange when 1 user is selected
  • [job] [logs] Jest Tests #14 / AssigneesFilterPopover calls onSelectionChange with a single user when different users are selected

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.3MB 2.3MB +145.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 marked this pull request as ready for review January 11, 2024 16:27
@dej611 dej611 requested a review from a team as a code owner January 11, 2024 16:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611
Copy link
Contributor Author

dej611 commented Jan 11, 2024

Just discovered that this PR has also the nice side effect to fix also #174154 .

stratoula
stratoula approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, LGTM

@dej611 dej611 merged commit 6c36503 into elastic:main Jan 12, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 12, 2024
@dej611 dej611 mentioned this pull request Jan 12, 2024
Closed
semd pushed a commit to semd/kibana that referenced this pull request Jan 12, 2024
@dej611 @semd
[ES|QL] Quote automatically for source/policies/fields with special c…
81e36c1 
…hars (elastic#174676)

## Summary

Add support for automatic quoting on autocomplete. Added tests.


![esql_quote_special_fields](https://github.com/elastic/kibana/assets/924948/c74d2535-5ff5-42fe-9ec8-285fc4818a3c)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dej611 @kibana-ci @elasticmachine @stratoula @kibanamachine