Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated node-sass with sass #2 #173942

Merged
merged 30 commits into from
Dec 28, 2023

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Dec 23, 2023

Summary

The previous PR #161813 was reverted due to the broken webpack config
eef1afc

@patrykkopycinski patrykkopycinski self-assigned this Dec 23, 2023
@patrykkopycinski patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label Dec 23, 2023
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbudz jbudz added ci:build-canvas-shareable-runtime ci:cloud-deploy Create or update a Cloud deployment labels Dec 26, 2023
@jbudz
Copy link
Member

jbudz commented Dec 26, 2023

buildkite test this

@patrykkopycinski
Copy link
Contributor Author

Thank you @jbudz for adding extra labels to test the config 🙇

@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 27, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Detection Engine - Security Solution Cypress Tests #4 / Timeline scope Modified badge Selecting new data view does not add a modified badge Selecting new data view does not add a modified badge

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1013.7KB 1013.7KB -2.0B
cloudSecurityPosture 452.0KB 452.1KB +12.0B
controls 199.7KB 199.7KB -6.0B
dashboard 377.6KB 377.6KB +4.0B
dataViewManagement 120.0KB 120.0KB -2.0B
dataVisualizer 617.4KB 617.4KB +10.0B
discover 592.4KB 592.4KB +14.0B
enterpriseSearch 2.7MB 2.7MB -52.0B
eventAnnotationListing 196.8KB 196.8KB +16.0B
filesManagement 89.9KB 89.9KB -4.0B
graph 387.3KB 387.3KB +8.0B
home 137.4KB 137.4KB -14.0B
indexManagement 585.2KB 585.2KB +6.0B
infra 1.3MB 1.3MB -4.0B
ingestPipelines 360.8KB 360.8KB -4.0B
kibanaOverview 46.6KB 46.6KB -4.0B
kibanaReact 214.5KB 214.7KB +194.0B
lens 1.4MB 1.4MB +4.0B
logExplorer 981.7KB 981.7KB +10.0B
management 75.0KB 75.0KB -4.0B
maps 2.9MB 2.9MB +36.0B
metricsDataAccess 85.2KB 85.2KB -4.0B
ml 3.6MB 3.6MB +28.0B
monitoring 462.2KB 462.2KB +66.0B
observabilityShared 36.3KB 36.3KB -4.0B
osquery 1.0MB 1.0MB -4.0B
presentationUtil 82.1KB 82.1KB +10.0B
security 575.6KB 575.6KB +16.0B
securitySolution 11.3MB 11.3MB +2.0B
securitySolutionEss 46.4KB 46.4KB -4.0B
securitySolutionServerless 361.2KB 361.2KB -4.0B
spaces 174.9KB 174.9KB -4.0B
stackAlerts 82.9KB 82.9KB +10.0B
unifiedDocViewer 58.4KB 58.4KB +6.0B
unifiedSearch 213.7KB 213.7KB +8.0B
visDefaultEditor 141.0KB 140.9KB -14.0B
visTypeTimelion 38.8KB 38.8KB -4.0B
visTypeVega 1.8MB 1.8MB -4.0B
visTypeVislib 339.7KB 339.7KB +40.0B
visualizations 266.9KB 266.9KB -28.0B
total +330.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5722 +5722
total size - 5.9MB +5.9MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 377.9KB 378.0KB +76.0B
embeddable 78.1KB 78.2KB +20.0B
esUiShared 155.8KB 155.8KB -4.0B
globalSearchBar 27.5KB 27.5KB -6.0B
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +280.0B
kibanaOverview 15.2KB 15.1KB -24.0B
kibanaReact 42.1KB 42.1KB -6.0B
osquery 51.2KB 51.2KB +10.0B
searchprofiler 18.7KB 18.8KB +18.0B
total +364.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@jbudz jbudz added the backport:all-open Backport to all branches that could still receive a release label Dec 28, 2023
@jbudz
Copy link
Member

jbudz commented Dec 28, 2023

This already received approvals in #161813. I verified the updates address storybook compilation.

@jbudz jbudz merged commit d4be2a3 into elastic:main Dec 28, 2023
42 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 28, 2023
## Summary

The previous PR elastic#161813 was
reverted due to the broken webpack config

elastic@eef1afc

---------

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
(cherry picked from commit d4be2a3)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 173942

Questions ?

Please refer to the Backport tool documentation

@jbudz
Copy link
Member

jbudz commented Dec 28, 2023

I closed the 8.12 backport, we just need 7.17 - targeting the same versions as the upgrade to Node 20.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 29, 2023
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 173942 locally

jbudz added a commit to jbudz/kibana that referenced this pull request Jan 2, 2024
The previous PR elastic#161813 was
reverted due to the broken webpack config

elastic@eef1afc

---------

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

jbudz added a commit that referenced this pull request Jan 3, 2024
#173942

---------

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release ci:build-canvas-shareable-runtime ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants