[Security Solution][Timeline] extract and cleanup timeline flyout component #173880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
PhilippeOberti
force-pushed
the
timeline-cleanup-part-2
branch
from
844a591 to
2f255f2
Compare
2 tasks
PhilippeOberti
force-pushed
the
timeline-cleanup-part-2
branch
from
2f255f2 to
2e72277
Compare
|
@elasticmachine merge upstream |
michaelolo24
reviewed
Jan 9, 2024
| @@ -90,7 +90,7 @@ export const SecuritySolutionTemplateWrapper: React.FC<Omit<KibanaPageTemplatePr | |||
| {isTimelineBottomBarVisible && ( | |||
| <KibanaPageTemplate.BottomBar data-test-subj="timeline-bottom-bar-container"> | |||
| <EuiThemeProvider colorMode={globalColorMode}> | |||
| <SecuritySolutionBottomBar /> | |||
| <Timeline /> | |||
There was a problem hiding this comment.
Such a simple change, yet so beautiful ❤️ 😄
michaelolo24
approved these changes
Jan 9, 2024
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.13.0
backport:skip
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Jan 10, 2024
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## NotesThis is a follow up PR to this one which should be merged first. The changes can be reviewed individually though, by ignoring the first commit and focusing only on the second.This PR is part of a long-running effort to clean up the timeline code. I originally had opened #172408 but the file count kept growing and so did the complexity for the reviewers. Of that original PR I will create probably 5-6 smaller ones.Summary
This very PR focuses on extracting the TimelineFlyout component:
flyoutfolder as timeline is no longer a flyout, but a modalwrapperandTimelineWrapperrespectively to better represent what the component actually doesThe PR also make the following small modifications
SecuritySolutionBottomBartoTimelinehas the component actually contains the bottom and the timeline modalAbsolutely no visual or behavior changes introduced here!
Checklist
The following PR will focus on the
FlyoutBottomBarcomponent.