Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Fix functions highlight with ES grammar #172287

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[ES|QL] Fix functions highlight with ES grammar #172287

merged 1 commit into from
Nov 30, 2023

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Nov 30, 2023

Summary

Fix ESQL function highlight as with the previous grammar.
Screenshot 2023-11-30 at 14 52 42

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana v8.12.0 labels Nov 30, 2023
@dej611 dej611 requested a review from a team as a code owner November 30, 2023 14:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611 dej611 mentioned this pull request Nov 30, 2023
Merged
23 tasks
stratoula
stratoula approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only. Will test on the feature branch

@dej611 dej611 merged commit 1641f7a into elastic:feature/esql-validation Nov 30, 2023
10 of 19 checks passed
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 30, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #3 / aiops change point detection shows multiple results when split field is selected
  • [job] [logs] FTR Configs #3 / aiops change point detection shows multiple results when split field is selected
  • [job] [logs] Security Solution Cypress Tests #11 / Detection ES|QL rules, creation creation creates an ES|QL rule and overrides its name creates an ES|QL rule and overrides its name
  • [job] [logs] Security Solution Cypress Tests #11 / Detection ES|QL rules, creation creation creates an ES|QL rule and overrides its name creates an ES|QL rule and overrides its name
  • [job] [logs] Security Solution Cypress Tests #11 / Detection ES|QL rules, creation ES|QL query validation proceeds further once invalid query is fixed proceeds further once invalid query is fixed
  • [job] [logs] Security Solution Cypress Tests #11 / Detection ES|QL rules, creation ES|QL query validation proceeds further once invalid query is fixed proceeds further once invalid query is fixed
  • [job] [logs] Security Solution Cypress Tests #11 / Detection ES|QL rules, creation ES|QL query validation shows error when non-aggregating ES|QL query does not return _id field shows error when non-aggregating ES|QL query does not return _id field
  • [job] [logs] Security Solution Cypress Tests #11 / Detection ES|QL rules, creation ES|QL query validation shows error when non-aggregating ES|QL query does not return _id field shows error when non-aggregating ES|QL query does not return _id field
  • [job] [logs] Security Solution Cypress Tests #3 / Detection ES|QL rules, edit adds ES|QL override rule name on edit adds ES|QL override rule name on edit
  • [job] [logs] Security Solution Cypress Tests #3 / Detection ES|QL rules, edit adds ES|QL override rule name on edit adds ES|QL override rule name on edit
  • [job] [logs] Security Solution Cypress Tests #3 / Detection ES|QL rules, edit edits ES|QL rule and checks details page edits ES|QL rule and checks details page
  • [job] [logs] Security Solution Cypress Tests #3 / Detection ES|QL rules, edit edits ES|QL rule and checks details page edits ES|QL rule and checks details page
  • [job] [logs] Security Solution Cypress Tests #3 / Detection ES|QL rules, edit edits ES|QL rule query and override rule name with new property edits ES|QL rule query and override rule name with new property
  • [job] [logs] Security Solution Cypress Tests #3 / Detection ES|QL rules, edit edits ES|QL rule query and override rule name with new property edits ES|QL rule query and override rule name with new property
  • [job] [logs] FTR Configs #55 / discover discover field visualize button should visualize correctly text based language queries in Discover
  • [job] [logs] FTR Configs #55 / discover discover field visualize button should visualize correctly text based language queries in Discover
  • [job] [logs] FTR Configs #6 / discover/group2 discover data grid field tokens should render field tokens correctly for ES|QL
  • [job] [logs] FTR Configs #6 / discover/group2 discover data grid field tokens should render field tokens correctly for ES|QL
  • [job] [logs] FTR Configs #20 / discover/group3 discover sidebar field filtering should show filters by type in text-based view
  • [job] [logs] FTR Configs #20 / discover/group3 discover sidebar field filtering should show filters by type in text-based view
  • [job] [logs] FTR Configs #48 / discover/group4 discover esql view test should render esql view correctly
  • [job] [logs] FTR Configs #48 / discover/group4 discover esql view test should render esql view correctly

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.3MB 2.3MB -107.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dej611 added a commit that referenced this pull request Dec 7, 2023
@dej611 @kibanamachine
@stratoula @abdonpijpelink
[ES|QL] Advanced validation and autocomplete (#170071)
ff49526 
## Summary

Fixes #166242 , #166876, #166173
, part of #166092, #166084

List of tasks:

* [x] AST work ( #166185 )
* [x] Basic validate work ( #166185 )
* [x] Hover feature ( #166185 )
* [x] Initial autocomplete work with new AST ( #166185 )
* Complete validation feature for MVP
  * [x] wildcards support ( #170014 )
  * [x] remote index validation support ( #171996 )
  * [x] wildcard support as `count` argument  ( #172054 )
  * [x] Aggressive caching for field queries:
* cache as much as possible the `FROM` queries - possible clear the
cache every 10/15 minutes?
    * do not fire a query when code == submitted code
* cache as much as possible the custom `FROM` built from `ENRICH`
policies - same clear policy as above
  * [x] Add unsupported fields warning messages
  * [x] Notify usage of `project` command with deprecation `warning`
* Complete autocomplete work ( #171664 )
  * [x] `stats`
  * [x] `where`
  * [x] `eval`
    * `math syntax`
  * [x] Aggressive cache for fields queries? ( #171866 )
  * [x] Fix when cursor is not at the end position ( #172060 ) 
* [x] Revisit copy messages
  * Label Kibana-only messages
* [x] Extend hover feature ( #171940 )
* [x] Disable editor query highlight for warnings ( #171968 )
* Fix editor highlight with new grammar
  * [x] on multi-line ( #172080 )
  * [x] for functions ( #172287 )

## Release notes

Enhance ES|QL query editing experience with client side validation.
Enhance ES|QL suggestions experience with more in context suggestions
leveraging field and variable types.
Show meta informations on ES|QL query hover on policy names.
Show function signature on ES|QL query hover on function text.


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dej611 @elasticmachine @kibana-ci @stratoula