Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Specific Cypress executions for
Rule Management
team #171868[Security Solution] Specific Cypress executions for
Rule Management
team #171868Changes from 12 commits
f143395
3fc3611
7110b01
705daa9
433e1b4
92b6ec2
1d9aec7
2677546
ee25e91
c1641bd
f80dc53
0fa496c
11c26ec
bfbac3e
b2d8075
5f29d05
babfb12
9a3db2d
69e7c79
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Hey @MadameSheema, was it necessary to move rule management tests outside of the
x-pack/test/security_solution_cypress/cypress/e2e/detection_response
folder tox-pack/test/security_solution_cypress/cypress/e2e/rule_management
? Can we move them back?I'd prefer having the following structure:
x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine
x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management
cc @yctercero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ on suggested change. I'm somewhat hesitant to base folder structure on teams (as we've updated teams several times), but I think it's needed in order to group the configs, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yctercero is around making it easier to maintain the scripts we use as well as checking as knowing by a quick look who is the owner. Another thing that I noticed when we didn't have this structure is that several tests didn't have ownership at all making hard to follow some automated flows on operations side.