Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Hide Logs tab in Rules page to unauthorized users, deduplicate rule types requests #171417

Merged
merged 25 commits into from
Dec 5, 2023
Merged

[RAM] Hide Logs tab in Rules page to unauthorized users, deduplicate rule types requests #171417

merged 25 commits into from
Dec 5, 2023

Conversation

umbopepato
Copy link
Member

Closes #158256, #155394

Summary

@umbopepato umbopepato added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0 release_note:fix labels Nov 16, 2023
@umbopepato umbopepato force-pushed the 158256-actions-role-sees-rules branch 2 times, most recently from e2d03a6 to 70a5d32 Compare November 21, 2023 11:40
@umbopepato umbopepato force-pushed the 158256-actions-role-sees-rules branch from 70a5d32 to 16760f4 Compare November 21, 2023 12:22
umbopepato and others added 10 commits November 21, 2023 15:08
@umbopepato umbopepato marked this pull request as ready for review November 29, 2023 16:04
@umbopepato umbopepato requested review from a team as code owners November 29, 2023 16:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Nov 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

JiaweiWu
JiaweiWu reviewed Dec 3, 2023
View reviewed changes
x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts Outdated
Comment on lines 25 to 26
// resolve(__dirname, './uptime'),
// resolve(__dirname, './ml'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental comments

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, thanks for spotting this!

x-pack/plugins/triggers_actions_ui/public/application/hooks/use_load_rule_types_query.ts
queryKey: ['loadRuleTypes'],
queryFn,
onError: onErrorFn,
refetchOnWindowFocus: false,
staleTime: 60 * 1000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave a comment here as to why we need to modify the stale time

JiaweiWu
JiaweiWu approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shahzad31
shahzad31 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obx UX Changes LGTM !!

@JiaweiWu JiaweiWu mentioned this pull request Dec 4, 2023
Merged
1 task
cauemarcondes
cauemarcondes approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umbopepato umbopepato enabled auto-merge (squash) December 5, 2023 10:43
@umbopepato umbopepato merged commit 0f5b544 into elastic:main Dec 5, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests on Serverless #5 / Response console Processes operations: "before all" hook for ""processes" - should obtain a list of processes" "before all" hook for ""processes" - should obtain a list of processes"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +17.0B
triggersActionsUi 1.4MB 1.4MB -3.2KB
total -3.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.2KB 105.0KB +725.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
triggersActionsUi 128 127 -1

Total ESLint disabled count

id before after diff
triggersActionsUi 134 133 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@JiaweiWu JiaweiWu JiaweiWu approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team:obs-ux-management Observability Management User Experience Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Response Ops] Rules navigation appears if user has access to Actions and Connectors but no rule types
8 participants
@umbopepato @elasticmachine @kibana-ci @shahzad31 @cauemarcondes @JiaweiWu @kibanamachine @XavierM