chore(deps): upgrade `supertest` and `superagent` #163716

afharo · 2023-08-11T13:52:06Z

Summary

I noticed that we cannot reenable the SSL redirect tests (#131192) because supertest/superagent fails to read the headers of the original request when creating the follow-up request.

kibana/test/server_integration/http/ssl_redirect/index.js

Line 22 in a86c016

    
           await supertest.get('/').redirects(1).expect('location', '/spaces/enter').expect(302);

This is the relevant piece of code failing in the library:

Old version: https://github.com/ladjs/superagent/blob/v3.8.3/lib/node/index.js#L419
New version: https://github.com/ladjs/superagent/blob/master/src/node/index.js#L513

Following any redirects makes Node.js crash because it's accessing req._headers, which is deprecated.

There's a known issue in the latest version of superagent when using the abort() method, though. There's a PR open to fix it ladjs/superagent#1774, and I updated the tests to workaround the bug.

For maintainers

This was checked for breaking API changes and was labeled appropriately

afharo · 2023-08-14T11:34:40Z

The tests that rely on request.abort() are failing due to a bug in superagent. I submitted ladjs/superagent#1774 to fix it on the library's end.

afharo · 2023-08-14T14:36:59Z

@elasticmachine merge upstream

elasticmachine · 2023-08-14T14:37:12Z

Pinging @elastic/apm-ui (Team:APM)

elasticmachine · 2023-08-14T14:37:33Z

Pinging @elastic/kibana-core (Team:Core)

afharo · 2023-08-14T15:13:15Z

@elasticmachine merge upstream

titanism · 2023-08-15T01:32:17Z

v8.1.0 released which fixes this issue, thank you

npm install superagent@8.1.0

release notes @ https://github.com/ladjs/superagent/releases/tag/v8.1.0

jloleysens

LGTM, did not test locally but happy to merge this with a happy CI

…ent-supertest

sorenlouv

apm change lgtm

afharo · 2023-08-16T09:05:01Z

@elasticmachine merge upstream

afharo · 2023-08-16T10:02:19Z

@elasticmachine merge upstream

kibana-ci · 2023-08-16T11:12:44Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 38a2699

Failed CI Steps

FTR Configs #30

Test Failures

[job] [logs] FTR Configs #30 / Synthetics API Tests EnableDefaultAlerting returns the created alerted when called

Metrics [docs]

✅ unchanged

History

💔 Build #150854 failed 833a843
💔 Build #150814 failed d0f5fca
💚 Build #150153 succeeded 5d712ea
💔 Build #150128 failed b15ecc8
💛 Build #150066 was flaky e264670

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

kibanamachine · 2023-08-16T11:18:56Z

💔 Some backports could not be created

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts You might need to backport the following PRs to 7.17: - Upgrade ESLint to v8 (#162309)
✅	8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 163716

Questions ?

Please refer to the Backport tool documentation

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 24312ab)

…64053) # Backport This will backport the following commits from `main` to `8.9`: - [chore(deps): upgrade `supertest` and `superagent` (#163716)](#163716)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 24312ab) # Conflicts: # package.json # yarn.lock

afharo · 2023-08-17T09:03:55Z

💚 All backports created successfully

Status	Branch	Result
✅	7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…164142) # Backport This will backport the following commits from `main` to `7.17`: - [chore(deps): upgrade `supertest` and `superagent` (#163716)](#163716)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) \n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

mistic · 2023-08-17T18:41:56Z

This pr didn't make it into the build candidate for v8.9.1. Updating the labels.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

afharo self-assigned this Aug 11, 2023

afharo added chore release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Aug 11, 2023

Upgrade supertest and superagent

0ef4fb7

afharo force-pushed the upgrade/superagent-supertest branch from 7a7a220 to 0ef4fb7 Compare August 11, 2023 14:02

Workaround superagent bug

e264670

afharo force-pushed the upgrade/superagent-supertest branch from 8b43e16 to e264670 Compare August 14, 2023 13:13

afharo marked this pull request as ready for review August 14, 2023 14:36

afharo requested review from a team as code owners August 14, 2023 14:36

Merge branch 'main' into upgrade/superagent-supertest

b15ecc8

botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 14, 2023

afharo added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Aug 14, 2023

Merge branch 'main' into upgrade/superagent-supertest

5d712ea

afharo enabled auto-merge (squash) August 14, 2023 16:27

jloleysens approved these changes Aug 15, 2023

View reviewed changes

afharo disabled auto-merge August 16, 2023 07:30

afharo added 2 commits August 16, 2023 09:49

Merge branch 'main' of github.com:elastic/kibana into upgrade/superag…

badb4f5

…ent-supertest

Bump superagent and remove workarounds

d0f5fca

afharo removed the request for review from a team August 16, 2023 08:05

afharo enabled auto-merge (squash) August 16, 2023 08:05

sorenlouv approved these changes Aug 16, 2023

View reviewed changes

Merge branch 'main' into upgrade/superagent-supertest

833a843

Merge branch 'main' into upgrade/superagent-supertest

38a2699

afharo mentioned this pull request Aug 16, 2023

chore(deps): upgrade @elastic/elasticsearch #163822

Merged

1 task

afharo merged commit 24312ab into elastic:main Aug 16, 2023

afharo deleted the upgrade/superagent-supertest branch August 16, 2023 11:12

kibanamachine added the v8.10.0 label Aug 16, 2023

kibanamachine mentioned this pull request Aug 16, 2023

[8.9] chore(deps): upgrade supertest and superagent (#163716) #164053

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 16, 2023

chore(deps): upgrade supertest and superagent (elastic#163716)

791ca39

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 24312ab)

kibanamachine added the v8.9.1 label Aug 16, 2023

hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Aug 16, 2023

chore(deps): upgrade supertest and superagent (elastic#163716)

c03c677

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

afharo mentioned this pull request Aug 17, 2023

[7.17] chore(deps): upgrade supertest and superagent (#163716) #164142

Merged

kibanamachine added the v7.17.13 label Aug 17, 2023

mistic added v8.9.2 and removed v8.9.1 labels Aug 17, 2023

bryce-b pushed a commit that referenced this pull request Aug 22, 2023

chore(deps): upgrade supertest and superagent (#163716)

18701be

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

dmlemeshko mentioned this pull request Aug 31, 2023

Integration tests fail with superagent: double callback bug #165380

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): upgrade `supertest` and `superagent` #163716

chore(deps): upgrade `supertest` and `superagent` #163716

afharo commented Aug 11, 2023 •

edited by kibanamachine

Loading

afharo commented Aug 14, 2023

afharo commented Aug 14, 2023

elasticmachine commented Aug 14, 2023

elasticmachine commented Aug 14, 2023

afharo commented Aug 14, 2023

titanism commented Aug 15, 2023

jloleysens left a comment

sorenlouv left a comment

afharo commented Aug 16, 2023

afharo commented Aug 16, 2023

kibana-ci commented Aug 16, 2023

kibanamachine commented Aug 16, 2023

afharo commented Aug 17, 2023

mistic commented Aug 17, 2023

chore(deps): upgrade supertest and superagent #163716

chore(deps): upgrade supertest and superagent #163716

Conversation

afharo commented Aug 11, 2023 • edited by kibanamachine Loading

Summary

For maintainers

afharo commented Aug 14, 2023

afharo commented Aug 14, 2023

elasticmachine commented Aug 14, 2023

elasticmachine commented Aug 14, 2023

afharo commented Aug 14, 2023

titanism commented Aug 15, 2023

jloleysens left a comment

Choose a reason for hiding this comment

sorenlouv left a comment

Choose a reason for hiding this comment

afharo commented Aug 16, 2023

afharo commented Aug 16, 2023

kibana-ci commented Aug 16, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

History

kibanamachine commented Aug 16, 2023

💔 Some backports could not be created

Manual backport

Questions ?

afharo commented Aug 17, 2023

💚 All backports created successfully

Questions ?

mistic commented Aug 17, 2023

chore(deps): upgrade `supertest` and `superagent` #163716

chore(deps): upgrade `supertest` and `superagent` #163716

afharo commented Aug 11, 2023 •

edited by kibanamachine

Loading