[Watcher] Retain query in watcher list #163297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:Watcher
Team:Kibana Management
|
@elasticmachine merge upstream |
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
There was a problem hiding this comment.
Thanks for patching this up @sabarasaba! Left one comment about surfacing the error message.
| @@ -446,7 +449,15 @@ export const WatchListPage = () => { | |||
| : '', | |||
| }; | |||
|
|
|||
| const handleOnChange = ({ queryText, error: queryError }: EuiSearchBarOnChangeArgs) => { | |||
| if (!queryError) { | |||
There was a problem hiding this comment.
Should we surface an error message if there is an error? Otherwise, it might not be clear to the user why a particular search returned no results.
There was a problem hiding this comment.
That makes sense! I've updated the changes and added a test too:
alisonelizabeth
approved these changes
Aug 8, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When working on #162687 we changed the table search to be controlled by the component it self. But as a side effect, the auto-refresh from the table clears up the query after x amount of time. We didnt caught this back then because the test that checks that was disabled and we only figured out after we tried to re-enable them with #162592.
This PR's patches it up so that we retain the query only when we dont have any errors.