Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations] Serverless yml settings #162959

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 2, 2023

Summary

Adds the necessary yml settings to the serverless config. These settings are making ui changes in dashboards / visualizations editors and they apply for all projects.

For testing run yarn start --serverless=es and check that the ui is working as expected with the legacy editors (TSVB, agg based) in a read only mode.

@stratoula
Copy link
Contributor Author

cc @elastic/kibana-visualizations @elastic/kibana-presentation for visibility

@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.10.0 labels Aug 2, 2023
@stratoula stratoula marked this pull request as ready for review August 2, 2023 10:50
@stratoula stratoula requested a review from a team as a code owner August 2, 2023 10:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stratoula stratoula merged commit 0fba094 into elastic:main Aug 7, 2023
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Aug 8, 2023
## Summary

Adds the necessary yml settings to the serverless config. These settings
are making ui changes in dashboards / visualizations editors and they
apply for all projects.

For testing run `yarn start --serverless=es` and check that the ui is
working as expected with the legacy editors (TSVB, agg based) in a read
only mode.
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
## Summary

Adds the necessary yml settings to the serverless config. These settings
are making ui changes in dashboards / visualizations editors and they
apply for all projects.

For testing run `yarn start --serverless=es` and check that the ui is
working as expected with the legacy editors (TSVB, agg based) in a read
only mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants