Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unskips jest integration test #162854

Merged

Conversation

TinaHeiligers
Copy link
Contributor

fix #108633

Unskip test to see if it's still failing in 7.17

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Risk Probability Severity Mitigation/Notes
The test becomes flaky again unknown unknown Integration tests will verify that the rolling file logging appended correctly rolls files when using the 'size-limit' policy with 'numeric' strategy

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Feature:Logging v7.17.13 labels Jul 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers
Copy link
Contributor Author

Manually rerunning the test to duplicate

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers requested review from mistic and a team August 1, 2023 21:47
@TinaHeiligers
Copy link
Contributor Author

The flaky test runner doesn't support jest integration tests. I've rerun these tests a few times and could do more but for now, maybe we should want and see if they fail again. WDYT?

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit 95ba923 into elastic:7.17 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logging release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants