[regression] Fix Storybooks after #161914 #162757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
review
loe:small
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
5 tasks
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
dgieselaar
approved these changes
Jul 30, 2023
rshen91
approved these changes
Jul 31, 2023
jbudz
approved these changes
Jul 31, 2023
cee-chen
added a commit
that referenced
this pull request
Aug 1, 2023
## Summary I missed my opportunity to leave this comment in #162757 before it merged 😅 EUI utilities should come after all other styles for CSS specificity order. ### Checklist N/A - internal infra change
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
## Summary As titled. This PR corrects a pair of mistakes I made before committing elastic#161914 that @dgieselaar identified shortly thereafter. - I had tested Storybook extensively, but after I rebased, I changed the render context, and I forgot to update the `decorator` in Storybook. This meant Emotion styles worked, but the EUI styles were missing. - In addition, when I rebased, I missed the addition of the utils cache that had been added by EUI. - Interestingly, elastic#162365 missed adding the cache `meta` tag to the template. Emotion simply added the styles to the `head`, but it's best to reproduce what we see in Kibana. So I've corrected that, as well. - While creating the PR, I went ahead and addressed [feedback](elastic#161914 (comment)) from @cee-chen on the original PR./ Sorry if anyone was confused by the sudden drop in styles in their Storybooks. Should be resolved now. Thanks! --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…#162855) ## Summary I missed my opportunity to leave this comment in elastic#162757 before it merged 😅 EUI utilities should come after all other styles for CSS specificity order. ### Checklist N/A - internal infra change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As titled. This PR corrects a pair of mistakes I made before committing #161914 that @dgieselaar identified shortly thereafter.
decoratorin Storybook. This meant Emotion styles worked, but the EUI styles were missing.metatag to the template. Emotion simply added the styles to thehead, but it's best to reproduce what we see in Kibana. So I've corrected that, as well.Sorry if anyone was confused by the sudden drop in styles in their Storybooks. Should be resolved now. Thanks!