Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ftr] define default FTR services for serverless #161946

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Jul 14, 2023

Cypress tests were failing with esArchiver service unavailability.

This PR fixes it by adding basic services (es, kibanaServier, esArchive & retry) from @kbn/ftr-common-functional-services in shared FTR configuration file. This way all the child config files will have these services pre-loaded.

@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jul 14, 2023
@@ -20,7 +20,6 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
...svlSharedConfig.get('esTestCluster.serverArgs'),
// define custom es server here
// API Keys is enabled at the top level
'xpack.security.enabled=true',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed on zoom, it is actually set to false for serverless

@dmlemeshko dmlemeshko marked this pull request as ready for review July 14, 2023 11:18
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of thanks @dmlemeshko!! With this now I'm able to setup the default auditbeat data I was looking for :)

Screenshot 2023-07-14 at 14 56 31

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 490 494 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko merged commit 818efd2 into elastic:main Jul 14, 2023
@dmlemeshko dmlemeshko deleted the ftr/add-default-services-in-shared-srvrless-config branch November 21, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants