Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Unregistering from/to fields for histogram indicator #161907

Merged

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jul 13, 2023

Summary

This PR fixes #161861 by adding shouldUnregister to the Controller components for indicator.params.from and indicator.params.to to ensure the fields are unregistered when they are unmounted.

Testing

  1. Create a new SLO using the histogram indicator.
  2. Set both the "good" and "total" events to use value count
  3. Ensure the preview chart displays data
  4. Set the "good" events to a range, the previous chart should update.

@simianhacker simianhacker added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0 labels Jul 13, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@simianhacker simianhacker added the release_note:skip Skip the PR/issue when compiling release notes label Jul 13, 2023
@simianhacker simianhacker marked this pull request as ready for review July 13, 2023 19:48
@simianhacker simianhacker requested a review from a team as a code owner July 13, 2023 19:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super fast approval because I tested the fix this AM on my side 😇

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +40.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 490 494 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit 29b22a3 into elastic:main Jul 14, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 14, 2023
@simianhacker simianhacker deleted the issue-161861-fix-histogram-indicator branch April 17, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] When switching from "range" to "value_count" histogram indicator becomes invalid.
6 participants