[Security Solution] Intercept individual package installation via Fleet #161859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdjere
added
test
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
jpdjere
force-pushed
the
fix-testing-prebuilt-rules
branch
from
24cc1f3
to
9fadb8d
Compare
|
Running the Flaky Test Runner for the SecuritySolution Cypress tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2629 |
terrancedejesus
approved these changes
Jul 13, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @jpdjere |
xcrzx
approved these changes
Jul 14, 2023
| // Under normal flow the package is installed via the Fleet bulk install API. | ||
| // However, for testing purposes the package can be installed via the Fleet individual install API, | ||
| // so we need to intercept and wait for that request as well. | ||
| if (!packagesBulkInstalled.includes('security_detection_engine')) { |
There was a problem hiding this comment.
It's okay to leave the logic here for now, but for a more robust solution, we should consider introducing an API endpoint on the detection engine side. This endpoint would handle all the complexities of package installation logic internally. We currently have duplication of this logic on both the frontend and backend. That could be part of Serverless: #150587.
kibanamachine
added
v8.10.0
backport:skip
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2023
…et (elastic#161859) ## Summary During Cypress tests, intercept `POST /api/fleet/epm/packages/security_detection_engine/*`. This is the endpoint used when a specific `security_detection_engine` package is set to be used via the `--xpack.securitySolution.prebuiltRulesPackageVersion` config flag, which is used to test by the TRADE team. This PR updates the test to account for that flow. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 45a483f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jpdjere
added a commit
that referenced
this pull request
Jul 16, 2023
…ia Fleet (#161859) (#161972) # Backport This will backport the following commits from `main` to `8.9`: - [[Security Solution] Intercept individual package installation via Fleet (#161859)](#161859) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"jpdjeredjian@gmail.com"},"sourceCommit":{"committedDate":"2023-07-14T13:49:42Z","message":"[Security Solution] Intercept individual package installation via Fleet (#161859)\n\n## Summary\r\n\r\nDuring Cypress tests, intercept `POST\r\n/api/fleet/epm/packages/security_detection_engine/*`.\r\n\r\nThis is the endpoint used when a specific `security_detection_engine`\r\npackage is set to be used via the\r\n`--xpack.securitySolution.prebuiltRulesPackageVersion` config flag,\r\nwhich is used to test by the TRADE team.\r\n\r\nThis PR updates the test to account for that flow.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"45a483f49643bcca4ff130d9f100c38a1a2181e7","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","backport:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","v8.10.0"],"number":161859,"url":"https://github.com/elastic/kibana/pull/161859","mergeCommit":{"message":"[Security Solution] Intercept individual package installation via Fleet (#161859)\n\n## Summary\r\n\r\nDuring Cypress tests, intercept `POST\r\n/api/fleet/epm/packages/security_detection_engine/*`.\r\n\r\nThis is the endpoint used when a specific `security_detection_engine`\r\npackage is set to be used via the\r\n`--xpack.securitySolution.prebuiltRulesPackageVersion` config flag,\r\nwhich is used to test by the TRADE team.\r\n\r\nThis PR updates the test to account for that flow.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"45a483f49643bcca4ff130d9f100c38a1a2181e7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161859","number":161859,"mergeCommit":{"message":"[Security Solution] Intercept individual package installation via Fleet (#161859)\n\n## Summary\r\n\r\nDuring Cypress tests, intercept `POST\r\n/api/fleet/epm/packages/security_detection_engine/*`.\r\n\r\nThis is the endpoint used when a specific `security_detection_engine`\r\npackage is set to be used via the\r\n`--xpack.securitySolution.prebuiltRulesPackageVersion` config flag,\r\nwhich is used to test by the TRADE team.\r\n\r\nThis PR updates the test to account for that flow.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"45a483f49643bcca4ff130d9f100c38a1a2181e7"}}]}] BACKPORT--> Co-authored-by: Juan Pablo Djeredjian <jpdjeredjian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During Cypress tests, intercept
POST /api/fleet/epm/packages/security_detection_engine/*.This is the endpoint used when a specific
security_detection_enginepackage is set to be used via the--xpack.securitySolution.prebuiltRulesPackageVersionconfig flag, which is used to test by the TRADE team.This PR updates the test to account for that flow.
For maintainers