Add error.grouping_name to group alerts in Error Count rule #161810
Conversation
benakansara
added
release_note:feature
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @benakansara |
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
benakansara
changed the title
| successful: 1, | ||
| total: 1, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
It would be better to have these as API tests (and thus avoid the mocking) if that's possible?
There was a problem hiding this comment.
@sqren I have added API tests in: x-pack/test/apm_api_integration/tests/alerts/error_count_threshold.spec.ts. Did you mean to add tests for any specific scenario or are these enough?
|
Pinging @elastic/apm-ui (Team:APM) |
Resolves https://github.com/elastic/actionable-observability/issues/70
For the APM Error Count rule -
error.grouping_namein the index mapping of AAD indexerror.grouping_namein the alert document in AAD indexerrorGroupingNamein the list of action variablesI discussed with @simianhacker regarding the alert instance ID having space/quotes with introduction of
errorGroupingName. It appears that usingerrorGroupingNameas is should not be an issue and so we don't need to modify or hash it.Group by dropdown
Reason message
Index mapping
Alert document
Action variable
Alert notification