Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] Support time series split for top hits per entity source #161799

Merged
merged 14 commits into from
Jul 14, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 12, 2023

Closes #141978

Screen Shot 2023-07-12 at 1 51 45 PM

Test instructions

  • clone https://github.com/thomasneirynck/faketracks
  • cd into faketracks
  • run npm install
  • run node ./generate_tracks.js --isTimeSeries
  • In Kibana, create tracks data view
  • In Maps, create new map and add Top hits layer. Select Tracks data view.

@nreese
Copy link
Contributor Author

nreese commented Jul 12, 2023

@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review July 13, 2023 14:09
@nreese nreese requested a review from a team as a code owner July 13, 2023 14:09
@nreese nreese added release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps v8.10.0 labels Jul 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Jul 13, 2023

@elasticmachine merge upstream

@jsanz
Copy link
Member

jsanz commented Jul 14, 2023

Commenting to keep the team review request.

Tested locally with the faketracks dataset, and it works as expected. The new workflow is straightforward. 👏

vokoscreenNG-2023-07-14_12-13-07.webm

@nickpeihl nickpeihl self-requested a review July 14, 2023 15:13
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested new top hits implementation on tsdb indices

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.8MB 2.8MB +2.2KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 490 494 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 2259e91 into elastic:main Jul 14, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Maps release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[maps] update top hits per entity and tracks implementation for time series indices
6 participants