-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maps] Support time series split for top hits per entity source #161799
Conversation
@elasticmachine merge upstream |
dd42cc4
to
ecc5839
Compare
a4f0a19
to
cbe7628
Compare
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
Commenting to keep the team review request. Tested locally with the vokoscreenNG-2023-07-14_12-13-07.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
code review and tested new top hits implementation on tsdb indices
x-pack/plugins/maps/public/classes/sources/es_search_source/top_hits/top_hits_form.tsx
Outdated
Show resolved
Hide resolved
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Closes #141978
Test instructions
faketracks
npm install
node ./generate_tracks.js --isTimeSeries
tracks
data viewTop hits
layer. SelectTracks
data view.