[Console] Filter autocomplete endpoints by availability #161781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Feature:Console
yuliacech
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Hi @ElenaStoeva, thanks a lot for working on this feature! I did an initial code review and changes LGTM. Also tested locally and the endpoints are correctly filtered out.
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
yuliacech
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Thanks a lot for adding the tests, @ElenaStoeva!
Tested locally and everything works as expected 👍
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
pgayvallet
approved these changes
Jul 14, 2023
thomheymann
approved these changes
Jul 14, 2023
kibanamachine
added
v8.10.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160160
Summary
This PR adds functionality to the new autocomplete generation script for creating an
availabilityproperty in the spec files that is used for filtering out endpoints that are not available in the current environment (e.g.serverlessorstack). It also adds a config setting in the console plugin that specifies the current environment. This setting is also configured accordingly for serverless.How to test
node scripts/generate_console_definitions.js --source <ES_SPECIFICATION_REPO> --emptyDestwhere<ES_SPECIFICATION_REPO>is the absolute path to the root of the ES specification repostackenvironment.serverlessenvironment.Here are some example endpoints that can be used for testing: