Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs onboarding] Landing page style changed #161542

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Jul 10, 2023

Relates to #159655.

Changes

This PR include the following changes:

  • Update the copy in the page subtitle with “Select your method for collecting data into Observability.”
  • Remove badges (Quickstart, in a few minutes, setup guide, integrations, sample data) from all cards
  • Remove ‘skip for now’ link
  • Change system logs card title with “Stream host system logs” and card description with “The quickest path to onboard log data from your own machine or server.”
  • Add system icon to system logs card
  • Change custom logs card title with “Stream log files” and card description with “Stream any logs into Elastic in a simple way and explore their data.”
  • Add logging icon to stream logs card
  • Remove horizontal line below the cards’ title
  • Add “Elastic agent” badge to system logs card and stream log files
  • Change CTA button text with ‘Get started’ of both system logs and stream log files card.
  • Remove the cards shadow and add 1px stroke Core/lightShade
  • Add 2px stroke Text/accentText around system logs card + Quickstart badge on top of the card
  • Remove ‘sample data’ card
  • Change APM card title with “Collect application performance data” and description with “Collect traces, logs, and metrics from OpenTelemetry or APM custom agent.”
  • Add secondary CTA button to APM card with the text “Get started” that links to the current flow
  • Add Elastic APM logo and Open Telemetry logo to APM card
  • Change Kubernetes card title with “Collect Kubernetes clusters data” and description with “Collect logs and metrics from Kubernetes clusters with Elastic agent.”
  • Add Kubernetes logo to Kubernetes card that links to the current setup guide
  • Add secondary CTA button to Kubernetes card with the text “Get started”
  • Create custom card for integrations with logs from: Amazon Kinesis, AWS, Apache, Nginx, Google Cloud Platform, Azure and card title “Explore 300+ ways of ingesting data with our integrations”
  • Add secondary CTA button to Integrations card with the text “Start exploring” that links to the Integrations page with ‘logs’ in the search bar
  • Add quick links to Integrations card to Use sample data (link to actual flow) + Upload file (link to actual flow) + AWS Firehose (link to docs: https://www.elastic.co/guide/en/kinesis/current/aws-firehose-setup-guide.html)

Missing

  • Link ‘Get started’ button from Stream log files directly to the stream log files onboarding flow (remove the select logs step)

This will be addressed in a follow up Pr since it's depending on #159500.

Screenshots

Before

image

After

image

@yngrdyn yngrdyn requested a review from a team as a code owner July 10, 2023 12:38
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Jul 10, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Jul 10, 2023

/oblt-deploy

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 39 66 +27

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 47.2KB 97.4KB +50.2KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

miscellaneous assets size

id before after diff
observabilityOnboarding 0.0B 8.9KB +8.9KB

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yngrdyn yngrdyn requested a review from ogupte July 11, 2023 16:41
@ogupte
Copy link
Contributor

ogupte commented Jul 14, 2023

FYI i don't see any of the changes in the cloud deployment:
Screenshot 2023-07-13 at 23 46 31

}
style={{
borderColor: euiTheme.colors.accent,
borderWidth: '2px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the px should be implied if you pass it as a Number type

Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yngrdyn yngrdyn merged commit 89d6cff into elastic:main Jul 14, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 14, 2023
@yngrdyn yngrdyn linked an issue Jul 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs onboarding] Design feedback
5 participants