Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless Search] Expanded unit testing #161356

Merged
merged 3 commits into from
Jul 10, 2023
Merged

[Serverless Search] Expanded unit testing #161356

merged 3 commits into from
Jul 10, 2023

Conversation

sloanelybutsurely
Copy link

@sloanelybutsurely sloanelybutsurely commented Jul 6, 2023 •
edited
Loading

Summary

Sets up unit testing for react components.

Unit testing of server-side components already implemented.

Checklist

@sloanelybutsurely sloanelybutsurely added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch labels Jul 7, 2023
@sloanelybutsurely sloanelybutsurely marked this pull request as ready for review July 7, 2023 16:54
@sloanelybutsurely sloanelybutsurely requested a review from a team July 7, 2023 16:54
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

History

  • 💔 Build #140656 failed 008241050839c0d427dde2620cf255a10c7d22df

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sphilipse
sphilipse approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thanks for setting this up! LGTM!

@sloanelybutsurely sloanelybutsurely merged commit 9f2a75b into elastic:main Jul 10, 2023
@sloanelybutsurely sloanelybutsurely deleted the serverless_search/unit-testing branch July 10, 2023 13:10
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sloanelybutsurely @kibana-ci @sphilipse @kibanamachine