[Cloud Security][FTR][Bug] Add a little delay for findings FTR for stability

[animehart]

Summary

• added 1s delay between adding a filter and checking the filter
• added 1s delay to allow both Kubernetes and Cloud tab to render on Dashboard page

[elasticmachine]

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

[kfirpeled]

@animehart increasing the sleep from 1s to 3s points to me that we are going in the wrong direction with that workaround.

We should be able to detect better when a sort action is over

[animehart]

@kfirpeled
I revert the 3s changes i made on my last PR as I realized adding delay on that line don't really fix anything, current fix is tested on Flaky test run for over 1000 cycles with 0 failures

[kfirpeled]

Instead of placing a sleep here we should check if we can wait for the tabs to appear with a timeout of 1s or 2s

[kfirpeled]

Instead of the following sleep we should call HeaderPageObject.awaitGlobalLoadingIndicatorHidden on before test

[kfirpeled]

When we went over the PR together we saw that we can have a reference to the header page object by calling

this.header = getPageObject('header')

in the DashboardPage. And later we can wait for the loading page to finish using awaitGlobalLoadingIndicatorHidden or waitUntilLoadingHasFinished

export function CspDashboardPageProvider({ getService, getPageObjects }: FtrProviderContext) {
  const PageObjects = getPageObjects(['common', 'header']);

// MORE CODE HERE ...

// PSEUDO USAGE:

    getDashboardTabs: async () => {
      // Waits for the page to load
      await PageObjects.header. awaitGlobalLoadingIndicatorHidden();
      // REST OF THE LOGIC
    },

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: a93f12f

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	14	16	+2
securitySolution	409	413	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	15	17	+2
securitySolution	488	492	+4
total			+6

History

• 💚 Build #141720 succeeded 9aac0be
• 💚 Build #141693 succeeded 98eb6b4
• 💛 Build #141337 was flaky d8cfbca
• 💔 Build #141083 failed 28e8f90
• 💚 Build #138929 succeeded e6afae7
• 💚 Build #138710 succeeded 2d484d7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[animehart]

tested on flaky test runner for 1110 cycles with 0 failures

[kfirpeled]

LGTM