Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Onboarding] API key generation states #159207

Merged

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Jun 7, 2023

closes #158567.

Summary

This PR introduces APIKey generation states.

Changes

  • Route POST /internal/observability_onboarding/custom_logs/install_shipper_setup was split into GET /internal/observability_onboarding/custom_logs/install_shipper_setup which is now in charge of determining current setup (kibana urls, es url) and POST /internal/observability_onboarding/custom_logs/save is now in charge of generating the apiKey and save the flow state.
  • Dedicated component ApiKeyBanner to handle the different states of the apiKey generation.

Screenshots

  • when ApiKey is being generated, notice the placeholder $API_KEY in script and yaml config
Screenshot 2023-06-07 at 15 16 03
  • when ApiKey has been successfully generated, notice the returned apiKey in script and yaml config
Screenshot 2023-06-07 at 15 15 01
  • when an error occurred while generating the ApiKey, notice the placeholder $API_KEY in script and yaml config
Screenshot 2023-06-07 at 15 13 21
  • when user doesn't have required permissions to generate the ApiKey, notice the placeholder $API_KEY in script and yaml config
Screenshot 2023-06-07 at 15 11 12

@yngrdyn yngrdyn requested a review from a team as a code owner June 7, 2023 13:24
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Jun 7, 2023
@yngrdyn yngrdyn force-pushed the 158567-logs-onboarding-api-key-generation-states branch 2 times, most recently from d28b43d to 95dc6ee Compare June 7, 2023 13:58
@achyutjhunjhunwala
Copy link
Contributor

@yngrdyn I guess the warning message here needs to be changed. I was using something similar previously for my PR

@sqren - I believe this is applicable here as well ?

@yngrdyn yngrdyn force-pushed the 158567-logs-onboarding-api-key-generation-states branch from 95dc6ee to c182f03 Compare June 7, 2023 15:13
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small nits, but it looks good.

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Jun 8, 2023

I guess the warning message here needs to be changed

@achyutjhunjhunwala and @sqren this was changed to
image

e4c6b8d

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #7 / machine learning - short tests model management trained models for ML power user with imported models starts deployment of the imported model pt_tiny_ner

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 35 36 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 41.7KB 44.6KB +2.8KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yngrdyn yngrdyn merged commit 4bc5e6c into elastic:main Jun 9, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs Onboarding] API key generation states
6 participants