-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs Onboarding] API key generation states #159207
[Logs Onboarding] API key generation states #159207
Conversation
…g-api-key-generation-states
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
d28b43d
to
95dc6ee
Compare
95dc6ee
to
c182f03
Compare
.../plugins/observability_onboarding/server/routes/custom_logs/has_log_monitoring_privileges.ts
Outdated
Show resolved
Hide resolved
...plugins/observability_onboarding/public/components/app/custom_logs/wizard/api_key_banner.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small nits, but it looks good.
@achyutjhunjhunwala and @sqren this was changed to |
…g-api-key-generation-states
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
closes #158567.
Summary
This PR introduces APIKey generation states.
Changes
POST /internal/observability_onboarding/custom_logs/install_shipper_setup
was split intoGET /internal/observability_onboarding/custom_logs/install_shipper_setup
which is now in charge of determining current setup (kibana urls, es url) andPOST /internal/observability_onboarding/custom_logs/save
is now in charge of generating the apiKey and save the flow state.ApiKeyBanner
to handle the different states of the apiKey generation.Screenshots
$API_KEY
in script and yaml config$API_KEY
in script and yaml config$API_KEY
in script and yaml config