Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.8] [Security Solution][Endpoint][Response Actions] Fix table navigation when trays are expanded (#157777) #158306

Merged
merged 2 commits into from
May 26, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

…when trays are expanded (elastic#157777)

## Summary

Fixes an issue where when an action detail is shown via an expanded tray
item and the total number of items goes beyond the first page on the
response actions history page/flyout, switching between pages while the
tray is open breaks the page.

- [x] fix paging with trays expanded on a flyout
- [x] fix paging with trays expanded on a page
- [x] ensure when the page is loaded with `?withOutputs=` with action
ids from different sets of pages, table paging doesn't break when paged,
and trays show open for the action ids in `?withOutputs=` URL param
- tests:
  - [x] page navigation flyout/page view
  - [x] page reload with URL params (cypress)

**flyout**

![response-logs-flyout](https://github.com/elastic/kibana/assets/1849116/c7c91d0d-3279-4813-b7dd-1365313b7fe4)

**page**

![response-logs-page](https://github.com/elastic/kibana/assets/1849116/b68f6e5d-9d0e-456f-8b07-dea07526571b)

*page with URL load*
- three actions are open on two different pages
- we re-load page 2 with two open trays and then navigate to page 1 to
see the third one open
- also re-load page 1; we see the tray open, then navigate to page 2 to
see the other two trays open.

![response-logs-page-reload](https://github.com/elastic/kibana/assets/1849116/58896b2e-4078-42c0-ac6c-c34d5b1cd42b)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 9e01dc8)
@ashokaditya ashokaditya enabled auto-merge (squash) May 26, 2023 12:51
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +428.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit b7375b0 into elastic:8.8 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants