Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(slo): Improve active alerts badge #155290

Merged
merged 1 commit into from
Apr 19, 2023
Merged

chore(slo): Improve active alerts badge #155290

merged 1 commit into from
Apr 19, 2023

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Apr 19, 2023 •
edited
Loading

Summary

Resolves #155288

This PR uses the new indexed field slo.id to filter the active alerts of a given SLO.
This also fixes an issue with showing old active alerts from deleted rules by filtering only the active alerts that have been updated in the past 15m (still runnning)

Screen.Recording.2023-04-19.at.11.16.22.AM.mov

@kdelemme kdelemme self-assigned this Apr 19, 2023
@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Apr 19, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme marked this pull request as ready for review April 19, 2023 15:17
@kdelemme kdelemme requested a review from a team as a code owner April 19, 2023 15:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

CoenWarmer
CoenWarmer approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 514 513 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB -16.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@kdelemme kdelemme merged commit 9ec31d0 into elastic:main Apr 19, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 19, 2023
@kdelemme kdelemme deleted the slo/use-slo-id-filter branch April 19, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoenWarmer CoenWarmer CoenWarmer approved these changes

Assignees

@kdelemme kdelemme

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLO] Improve active alerts badge
6 participants
@kdelemme @apmmachine @elasticmachine @kibana-ci @CoenWarmer @kibanamachine