Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Un-skip and fix tests for Response Actions History Log #154865

Merged
merged 2 commits into from
Apr 13, 2023
Merged

[Security Solution][Endpoint] Un-skip and fix tests for Response Actions History Log #154865

merged 2 commits into from
Apr 13, 2023

Conversation

paul-tavares
Copy link
Contributor

Summary

  • Un-skips and fixes tests for the Response Actions History Log

Fixes: #153556
Fixes: #145635

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0 labels Apr 12, 2023
@paul-tavares paul-tavares requested a review from a team as a code owner April 12, 2023 19:18
@paul-tavares paul-tavares self-assigned this Apr 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@paul-tavares paul-tavares requested review from pzl and removed request for ashokaditya April 12, 2023 19:18
pzl
pzl approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.9MB 15.9MB +30.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@paul-tavares paul-tavares merged commit 2d7fb43 into elastic:main Apr 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 13, 2023
@paul-tavares paul-tavares deleted the task/olm-153556-failed-test-fix branch April 13, 2023 13:26
This was referenced May 2, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzl pzl pzl approved these changes

@gergoabraham gergoabraham gergoabraham approved these changes

Assignees

@paul-tavares paul-tavares

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0
Projects
None yet
Milestone
No milestone
6 participants
@paul-tavares @elasticmachine @kibana-ci @pzl @gergoabraham @kibanamachine