Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Add eui error boundary to observability pages #152786

Merged
merged 3 commits into from
Mar 8, 2023
Merged

[AO] Add eui error boundary to observability pages #152786

merged 3 commits into from
Mar 8, 2023

Conversation

maryam-saeidi
Copy link
Member

Closes #152785

Summary

Inspired by #65456

Before After
image image

@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Mar 7, 2023
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner March 7, 2023 09:23
@maryam-saeidi maryam-saeidi self-assigned this Mar 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +86.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 505 507 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

benakansara
benakansara approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice improvement! 👏

@maryam-saeidi maryam-saeidi merged commit 662689b into elastic:main Mar 8, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 8, 2023
@maryam-saeidi maryam-saeidi deleted the 152785-add-error-boundary branch March 8, 2023 11:52
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@maryam-saeidi @bmorelli25
[AO] Add eui error boundary to observability pages (elastic#152786)
a5d88e9 
Closes elastic#152785 

## Summary

Inspired by elastic#65456

|Before|After|
|---|---|

|![image](https://user-images.githubusercontent.com/12370520/223378684-3d7927cf-b1f3-4ebf-a4b8-9deab9bcc23b.png)|![image](https://user-images.githubusercontent.com/12370520/223378731-4c4861f7-afaf-42f8-bc47-9c4a0d7454ec.png)|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benakansara benakansara benakansara approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AO] Add eui error boundary to observability plugin
5 participants
@maryam-saeidi @elasticmachine @kibana-ci @benakansara @kibanamachine