Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - fix report names in API configs #152591

Merged
merged 1 commit into from
Mar 6, 2023
Merged

[ML] Functional tests - fix report names in API configs #152591

merged 1 commit into from
Mar 6, 2023

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Mar 2, 2023 •
edited by kibanamachine
Loading

Summary

This PR fixes the API integration test suite report names for ML and Transform tests.

Follow-up on #151729, where the suite names have been introduced with a copy/paste mistake.

@pheyos pheyos added :ml release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.7.0 v8.8.0 labels Mar 2, 2023
@pheyos pheyos requested review from walterra and peteharverson March 2, 2023 16:03
@pheyos pheyos requested a review from a team as a code owner March 2, 2023 16:03
@pheyos pheyos self-assigned this Mar 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

peteharverson
peteharverson approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry I didn't spot your deliberate typo in the original PR ;)

@pheyos pheyos merged commit 61f0a39 into elastic:main Mar 6, 2023
@pheyos pheyos deleted the fix_report_names branch March 6, 2023 09:53
@kibanamachine kibanamachine mentioned this pull request Mar 6, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 6, 2023
@pheyos
[ML] Functional tests - fix report names in API configs (elastic#152591)
1909c84 
This PR fixes the API integration test suite report names for ML and Transform tests.

(cherry picked from commit 61f0a39)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 6, 2023
@kibanamachine @pheyos
[8.7] [ML] Functional tests - fix report names in API configs (#152591)…
5178d15 
… (#152692)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[ML] Functional tests - fix report names in API configs
(#152591)](#152591)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Oskamp","email":"robert.oskamp@elastic.co"},"sourceCommit":{"committedDate":"2023-03-06T09:52:08Z","message":"[ML]
Functional tests - fix report names in API configs (#152591)\n\nThis PR
fixes the API integration test suite report names for ML and Transform
tests.","sha":"61f0a39e28820bd165318ddcd9e417869141be75","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","backport:prev-minor","v8.7.0","v8.8.0"],"number":152591,"url":"https://github.com/elastic/kibana/pull/152591","mergeCommit":{"message":"[ML]
Functional tests - fix report names in API configs (#152591)\n\nThis PR
fixes the API integration test suite report names for ML and Transform
tests.","sha":"61f0a39e28820bd165318ddcd9e417869141be75"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152591","number":152591,"mergeCommit":{"message":"[ML]
Functional tests - fix report names in API configs (#152591)\n\nThis PR
fixes the API integration test suite report names for ML and Transform
tests.","sha":"61f0a39e28820bd165318ddcd9e417869141be75"}}]}]
BACKPORT-->

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@pheyos @bmorelli25
[ML] Functional tests - fix report names in API configs (elastic#152591)
8bf5e54 
This PR fixes the API integration test suite report names for ML and Transform tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@pheyos pheyos

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) :ml release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pheyos @elasticmachine @kibana-ci @kibanamachine @peteharverson