Removes FindQueryHTTP['fields'] option in Saved Objects Management #152306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
|
@elasticmachine merge upstream |
TinaHeiligers
commented
Feb 28, 2023
| @@ -236,7 +236,6 @@ export class SavedObjectsTable extends Component<SavedObjectsTableProps, SavedOb | |||
| search: queryText ? `${queryText}*` : undefined, | |||
| perPage, | |||
| page: page + 1, | |||
| fields: ['id'], | |||
There was a problem hiding this comment.
Rather than trying hard coding the option, I've removed it instead.
| @@ -90,9 +89,6 @@ export const registerFindRoute = ( | |||
| saved_objects: savedObjects.map((so) => { | |||
| const obj = injectMetaAttributes(so, managementService); | |||
| const result = { ...obj, attributes: {} as Record<string, unknown> }; | |||
| for (const field of includedFields) { | |||
There was a problem hiding this comment.
Removes handling the 'fields' option in the query since we don't want to explicitly expose attributes in the response
| @@ -37,7 +37,7 @@ export default function ({ getService }: FtrProviderContext) { | |||
|
|
|||
| it('should return 200 with individual responses', async () => | |||
| await supertest | |||
| .get('/api/kibana/management/saved_objects/_find?type=visualization&fields=title') | |||
Bamieh
reviewed
Feb 28, 2023
| }), | ||
| // fields: schema.oneOf([schema.string(), schema.arrayOf(schema.string())], { | ||
| // defaultValue: [], | ||
| // }), |
There was a problem hiding this comment.
i think you want to remove the fields schema rather than comment it out
jloleysens
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Great work @TinaHeiligers ! Pending @Bamieh 's comment, this LGTM. I tested locally and worked as expected.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
TinaHeiligers
deleted the
kbn-151427-findqueryhttp-type-remove-fields
branch
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…lastic#152306) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #151427
The saved object's management (SOM) plugin allowed specifying saved object attributes by optionally accepting a
fieldsoption in_findcalls.This means that we could potentially leak the internal structure of saved objects in the browser.
Note: The SOM api's were not intended to be public, and this change is therefore not considered a breaking API change.
Checklist
Risk Matrix
fieldsquery returns a bad request; external plugins depending on the SOM feature no longer return expected results.For maintainers