Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exceptions] - Fix export toast message #152301

Merged
merged 4 commits into from
Mar 1, 2023
Merged

[Security Solution][Exceptions] - Fix export toast message #152301

merged 4 commits into from
Mar 1, 2023

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Feb 27, 2023 •
edited by kibanamachine
Loading

Summary

Addresses #145680

Screenshot 2023-02-27 at 3 17 03 PM

Screenshot 2023-02-27 at 3 17 16 PM

Checklist

@yctercero yctercero added bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform Security Solution Platform Team v8.7.0 labels Feb 27, 2023
@yctercero yctercero requested a review from a team as a code owner February 27, 2023 23:21
@yctercero yctercero self-assigned this Feb 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@yctercero
Copy link
Contributor Author

@elastic/security-docs pinging in case any sreenshots in docs need updating

@joepeeples
Copy link
Contributor

@elastic/security-docs pinging in case any sreenshots in docs need updating

Thanks again for the ping! I don't think this involves docs updates; we don't directly document or reference the toast message.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #2 / Related integrations installed integrations: Amazon CloudFront, AWS CloudTrail, System, enabled integrations: Amazon CloudFront, Aws Cloudfront, System "before all" hook for "should display a badge with the installed integrations on the rule management page"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.7MB 15.7MB -480.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit df2869a into elastic:main Mar 1, 2023
@kibanamachine kibanamachine mentioned this pull request Mar 1, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 1, 2023
@yctercero
[Security Solution][Exceptions] - Fix export toast message (elastic#1…
88ad5cd 
…52301)

## Summary

Addresses elastic#145680

(cherry picked from commit df2869a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 1, 2023
@kibanamachine @yctercero
[8.7] [Security Solution][Exceptions] - Fix export toast message (#15…
63d4d3a 
…2301) (#152517)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution][Exceptions] - Fix export toast message
(#152301)](#152301)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-03-01T21:33:50Z","message":"[Security
Solution][Exceptions] - Fix export toast message (#152301)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/145680","sha":"df2869a5fefeec28f1f796630fff85708a59163a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:
SecuritySolution","Team:Security Solution
Platform","v8.7.0","v8.8.0"],"number":152301,"url":"https://github.com/elastic/kibana/pull/152301","mergeCommit":{"message":"[Security
Solution][Exceptions] - Fix export toast message (#152301)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/145680","sha":"df2869a5fefeec28f1f796630fff85708a59163a"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152301","number":152301,"mergeCommit":{"message":"[Security
Solution][Exceptions] - Fix export toast message (#152301)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/145680","sha":"df2869a5fefeec28f1f796630fff85708a59163a"}}]}]
BACKPORT-->

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
@yctercero yctercero deleted the 145680 branch March 2, 2023 21:26
@dplumlee dplumlee mentioned this pull request Mar 5, 2023
Merged
4 tasks
dplumlee added a commit that referenced this pull request Mar 5, 2023
@dplumlee
[Security Solution] Fixes breaking type in main (#152654)
05f306c 
Addresses #152653

Fixes a merge conflict that somehow made its way into main between these
two PRs ([1](#152301),
[2](#151952))
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@yctercero @bmorelli25
[Security Solution][Exceptions] - Fix export toast message (elastic#1…
adaff0a 
…52301)

## Summary

Addresses elastic#145680
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@dplumlee @bmorelli25
[Security Solution] Fixes breaking type in main (elastic#152654)
e5419d2 
Addresses elastic#152653

Fixes a merge conflict that somehow made its way into main between these
two PRs ([1](elastic#152301),
[2](elastic#151952))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 dhurley14 approved these changes

Assignees

@yctercero yctercero

Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yctercero @elasticmachine @joepeeples @kibana-ci @kibanamachine @dhurley14