unskip Chrome UI Functional Tests.test/functional/apps/dashboard/group3/dashboard_state·ts #152245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ref HEAD~1..HEAD --fix'
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
nickpeihl
approved these changes
Feb 28, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…p3/dashboard_state·ts (elastic#152245) Fixes elastic#139762 flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1965 2 changes where required to get functional tests running * Switch application state updating from string replace to rison decode/encode. `_a` is not longer provided in the URL unless there are unsaved changes to simple string replace did not work in some cases. Using rison decode/encode was easier then handling a lot of if statements around whether `_a` exists before attempting string replace, plus rison decode/encode is a lot more maintainable and robust. * Fix bug where appending `&_a=(panels:())` to URL would not remove panels. Updated logic in sync_dashboard_url_state to handle case where panels has no length. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139762
flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1965
2 changes where required to get functional tests running
_ais not longer provided in the URL unless there are unsaved changes to simple string replace did not work in some cases. Using rison decode/encode was easier then handling a lot of if statements around whether_aexists before attempting string replace, plus rison decode/encode is a lot more maintainable and robust.&_a=(panels:())to URL would not remove panels. Updated logic in sync_dashboard_url_state to handle case where panels has no length.