[ML] Data Frame Analytics exploration: adds actions column with link to discover #151482
Conversation
alvarezmelissa87
added
release_note:enhancement
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
| query: indexData.visibleColumns | ||
| .filter((column) => !column.includes(resultsField!)) | ||
| .map((column) => { | ||
| if (item[column] !== undefined) { |
There was a problem hiding this comment.
if item[column] is undefined it looks like this string will be incorrect as undefined will be added to it.
Maybe there should be a filter before the map to remove this risk?
There was a problem hiding this comment.
Oh yes! Good catch - I'll add it to the filter above 👍
Fixed in 7aea101
|
The reference in the EUI docs uses a bit of a different layout (different icon, narrower column with no label, instead the "Actions" label is in the tooltip). Wonder if we should stick more to the reference?
|
Yeah - I can do that. Right now it reflects the anomalies table Actions column - so depends on if we want to be consistent with the example or the anomalies table. cc @walterra, @peteharverson |
|
This is ready for another look when you get a chance 🙏 cc @jgowdyelastic, @walterra (@peteharverson for layout approval) |
| filters: data.query.filterManager.getFilters(), | ||
| query: { | ||
| language: SEARCH_QUERY_LANGUAGE.KUERY, | ||
| // Filter for all visible column values of supported types - except the results field values |
There was a problem hiding this comment.
I did wonder if we should add all columns to the filter, but that could potentially be a lot of columns. This way the user can control the filter by showing / hiding columns from the grid, so I think this makes sense.
| } | ||
| }, | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [indexData?.visibleColumns, discoverLocator, dataViewId, resultsField, tableItems] |
There was a problem hiding this comment.
can data be included here to remove the need to suppress this error?
There was a problem hiding this comment.
Included in 1664d29
| ]; | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
looks like this fragment isn't needed
There was a problem hiding this comment.
Removed in 1664d29
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
szabosteve
changed the title
Summary
Related issue: #150375
This PR adds an 'Actions' column to the results data grid and provides a link to Discover filtering for the row's field/values shown in the columns.
Checklist
Delete any items that are not applicable to this PR.