Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Show error for crawlers without a connector document #150928

Merged

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Feb 10, 2023

Summary

This shows an error for broken crawlers, where a connector document has been deleted. It offers users the choice to recreate the connector or delete their index.

Screen.Recording.2023-02-28.at.16.28.50.mov
Screen.Recording.2023-02-28.at.17.29.34.mov

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.7.0 v8.8.0 labels Feb 10, 2023
@sphilipse sphilipse requested a review from a team February 10, 2023 17:11
@sphilipse sphilipse force-pushed the ent-search-3764-error-connector-crawler branch from ff7c62a to ef42e91 Compare February 28, 2023 16:31
@sphilipse sphilipse force-pushed the ent-search-3764-error-connector-crawler branch from ef42e91 to 83e21bd Compare February 28, 2023 16:35
@zombieFox zombieFox requested a review from a team February 28, 2023 16:47
@sphilipse sphilipse enabled auto-merge (squash) February 28, 2023 17:13
Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2014 2017 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.2MB 2.2MB +1.9KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit 6be7e3d into elastic:main Feb 28, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 28, 2023
…ent (elastic#150928)

## Summary

This shows an error for broken crawlers, where a connector document has
been deleted. It offers users the choice to recreate the connector or
delete their index.

https://user-images.githubusercontent.com/94373878/221916920-f75299b4-f88d-4cba-89a2-92fe62366050.mov

https://user-images.githubusercontent.com/94373878/221916935-b416a782-92b4-4795-a1af-73e97fa523c8.mov
(cherry picked from commit 6be7e3d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 28, 2023
… document (#150928) (#152400)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Enterprise Search] Show error for crawlers without a connector
document (#150928)](#150928)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-28T22:23:04Z","message":"[Enterprise
Search] Show error for crawlers without a connector document
(#150928)\n\n## Summary\r\n\r\nThis shows an error for broken crawlers,
where a connector document has\r\nbeen deleted. It offers users the
choice to recreate the connector or\r\ndelete their
index.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/94373878/221916920-f75299b4-f88d-4cba-89a2-92fe62366050.mov\r\n\r\n\r\nhttps://user-images.githubusercontent.com/94373878/221916935-b416a782-92b4-4795-a1af-73e97fa523c8.mov","sha":"6be7e3df0b8f55e45a114e8da66c2dd1927ca341","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.7.0","v8.8.0"],"number":150928,"url":"https://github.com/elastic/kibana/pull/150928","mergeCommit":{"message":"[Enterprise
Search] Show error for crawlers without a connector document
(#150928)\n\n## Summary\r\n\r\nThis shows an error for broken crawlers,
where a connector document has\r\nbeen deleted. It offers users the
choice to recreate the connector or\r\ndelete their
index.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/94373878/221916920-f75299b4-f88d-4cba-89a2-92fe62366050.mov\r\n\r\n\r\nhttps://user-images.githubusercontent.com/94373878/221916935-b416a782-92b4-4795-a1af-73e97fa523c8.mov","sha":"6be7e3df0b8f55e45a114e8da66c2dd1927ca341"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150928","number":150928,"mergeCommit":{"message":"[Enterprise
Search] Show error for crawlers without a connector document
(#150928)\n\n## Summary\r\n\r\nThis shows an error for broken crawlers,
where a connector document has\r\nbeen deleted. It offers users the
choice to recreate the connector or\r\ndelete their
index.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/94373878/221916920-f75299b4-f88d-4cba-89a2-92fe62366050.mov\r\n\r\n\r\nhttps://user-images.githubusercontent.com/94373878/221916935-b416a782-92b4-4795-a1af-73e97fa523c8.mov","sha":"6be7e3df0b8f55e45a114e8da66c2dd1927ca341"}}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <94373878+sphilipse@users.noreply.github.com>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants