Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Improve index connector, automate screenshots #150126

Merged
merged 5 commits into from
Feb 7, 2023
Merged

[DOCS] Improve index connector, automate screenshots #150126

merged 5 commits into from
Feb 7, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 2, 2023 •
edited by kibanamachine
Loading

Summary

Relates to #140222, #100268

This PR edits the content in https://www.elastic.co/guide/en/kibana/master/index-action-type.html as follows:

  • Automates two of the screenshots
  • Adds the missing setting details for the preconfigured connector example
  • Clarifies that you can create the connector via API or Kibana or preconfigured settings
  • Makes some minor edits to align changes in the server log connector docs

@lcawl lcawl added the docs label Feb 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Documentation preview:

@lcawl lcawl added Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0 backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Feb 2, 2023
@lcawl lcawl marked this pull request as ready for review February 2, 2023 15:12
@lcawl lcawl requested a review from a team as a code owner February 2, 2023 15:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

pmuellr
pmuellr approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl enabled auto-merge (squash) February 7, 2023 15:34
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 6f90821 into elastic:main Feb 7, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.6 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 150126

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl deleted the index-connector branch February 7, 2023 19:30
@lcawl lcawl mentioned this pull request Feb 8, 2023
Merged
@lcawl
Copy link
Contributor Author

lcawl commented Feb 8, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request Feb 8, 2023
@lcawl
[DOCS] Improve index connector, automate screenshots (elastic#150126)
d66b14f 
(cherry picked from commit 6f90821)
lcawl added a commit that referenced this pull request Feb 8, 2023
@lcawl
[8.6] [DOCS] Improve index connector, automate screenshots (#150126) (#…
9cf85b6 
…150508)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[DOCS] Improve index connector, automate screenshots
(#150126)](#150126)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-02-07T16:42:09Z","message":"[DOCS]
Improve index connector, automate screenshots
(#150126)","sha":"6f908219060ceac5415421061642d90cadf76cd5","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorTypes","backport:prev-minor","v8.7.0"],"number":150126,"url":"https://github.com/elastic/kibana/pull/150126","mergeCommit":{"message":"[DOCS]
Improve index connector, automate screenshots
(#150126)","sha":"6f908219060ceac5415421061642d90cadf76cd5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150126","number":150126,"mergeCommit":{"message":"[DOCS]
Improve index connector, automate screenshots
(#150126)","sha":"6f908219060ceac5415421061642d90cadf76cd5"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.2 v8.7.0
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @elasticmachine @kibana-ci @kibanamachine @pmuellr