Implement package linter

[spalger]

This PR implements a linter like the TS Project linter, except for packages in the repo. It does this by extracting the reusable bits from the TS Project linter and reusing them for the project linter. The only rule that exists for packages right now is that the "name" in the package.json file matches the "id" in Kibana.jsonc. The goal is to use a rule to migrate kibana.json files on the future.

Additionally, a new rule for validating the indentation of tsconfig.json files was added.

Validating and fixing violations is what has triggered review by so many teams, but we plan to treat those review requests as notifications of the changes and not as blockers for merging.

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[TinaHeiligers]

Changes in core-owned packages are white-space related.
LGTM

[stratoula]

Visualizations team changes LGTM!

[PhilippeOberti]

Protections Experience changes LGTM!

[walterra]

ML team changes LGTM

[ThomThomson]

Presentation team changes in canvas tsconfig LGTM. Does the new linting system highlight unused references in the tsconfig now?

[spalger]

Presentation team changes in canvas tsconfig LGTM. Does the new linting system highlight unused references in the tsconfig now?

@ThomThomson It doesn't just highlight them, it automatically removes then on CI and when you execute node scripts/lint_ts_projects --fix

[mistic]

lgtm

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 72ccf51

Failed CI Steps

• Synthetics @elastic/synthetics Tests
• Synthetics @elastic/synthetics Tests
• Post-Build
• Post-Build

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/json-ast	-	28	+28
@kbn/repo-file-maps	-	18	+18
@kbn/repo-linter	-	38	+38
@kbn/sort-package-json	2	0	-2
@kbn/ts-project-linter	9	-	-9
@kbn/ts-projects	16	25	+9
total			+82

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
@kbn/json-ast	-	2	+2

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/bazel-packages	1	-	-1
@kbn/package-map	1	-	-1
@kbn/repo-linter	-	5	+5
@kbn/repo-packages	-	3	+3
@kbn/ts-project-linter	1	-	-1
total			+5

Unknown metric groups

API count

id	before	after	diff
@kbn/json-ast	-	32	+32
@kbn/repo-file-maps	-	18	+18
@kbn/repo-linter	-	40	+40
@kbn/repo-path	11	12	+1
@kbn/sort-package-json	2	0	-2
@kbn/ts-project-linter	9	-	-9
@kbn/ts-projects	27	38	+11
total			+91

ESLint disabled in files

id	before	after	diff
@kbn/bazel-packages	1	-	-1
@kbn/import-locator	-	2	+2
@kbn/repo-packages	-	1	+1
@kbn/ts-project-linter	2	-	-2
total			-0

Total ESLint disabled count

id	before	after	diff
@kbn/bazel-packages	1	-	-1
@kbn/import-locator	-	2	+2
@kbn/repo-packages	-	1	+1
@kbn/ts-project-linter	2	-	-2
total			-0

History

• 💔 Build #98888 failed 73f0edb
• 💛 Build #98546 was flaky d82d203
• 💛 Build #98531 was flaky 3119f2c
• 💔 Build #98530 failed 7c117bc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream