Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Visualisation actions button is overlap on to the bar chart #145973

Merged
merged 3 commits into from
Nov 23, 2022
Merged

[Security Solution] Visualisation actions button is overlap on to the bar chart #145973

merged 3 commits into from
Nov 23, 2022

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Nov 22, 2022 •
edited by kibanamachine
Loading

Summary

Original issue: Visualisation actions button is overlap on to the bar chart.
#128344

Before:
Screenshot 2022-11-22 at 11 31 19

After:
Screenshot 2022-11-22 at 11 30 39

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.6.0 v8.5.2 release_note:skip Skip the PR/issue when compiling release notes labels Nov 22, 2022
@angorayc angorayc changed the title Issue/128344 [Security Solution] Visualisation actions button is overlap on to the bar chart Nov 22, 2022
@angorayc angorayc marked this pull request as ready for review November 22, 2022 12:25
@angorayc angorayc requested review from a team as code owners November 22, 2022 12:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

machadoum
machadoum reviewed Nov 22, 2022
View reviewed changes
...mmon/components/visualization_actions/lens_attributes/users/kpi_user_authentications_area.ts Outdated
@@ -15,7 +15,7 @@ export const kpiUserAuthenticationsAreaLensAttributes: LensAttributes = {
state: {
visualization: {
axisTitlesVisibilitySettings: {
x: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, Pablo, https://github.com/elastic/kibana/pull/145896/files should cover this. I'll revert this change.

machadoum
machadoum approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you check the comment I left?

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #4 / Timeline search and filters Update kqlMode for timeline "before all" hook for "should be able to update timeline kqlMode with filter"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.7MB 9.7MB +483.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc removed the v8.5.2 label Nov 23, 2022
@angorayc angorayc merged commit a065866 into elastic:main Nov 23, 2022
@angorayc angorayc added the fixed label Nov 23, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 23, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 23, 2022
@angorayc
[Security Solution] Visualisation actions button is overlap on to the…
4f5d33b 
… bar chart (elastic#145973)

## Summary

Original issue: Visualisation actions button is overlap on to the bar
chart.
elastic#128344

Before:
<img width="575" alt="Screenshot 2022-11-22 at 11 31 19"
src="https://user-images.githubusercontent.com/6295984/203304147-ff0ec823-182c-40bf-8da5-fa45180eae0a.png">

After:
<img width="765" alt="Screenshot 2022-11-22 at 11 30 39"
src="https://user-images.githubusercontent.com/6295984/203304150-5dae9a4a-341d-4717-abb1-f56aa20ba6bd.png">

(cherry picked from commit a065866)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 23, 2022
@kibanamachine @angorayc
[8.6] [Security Solution] Visualisation actions button is overlap on …
f776764 
…to the bar chart (#145973) (#146106)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Security Solution] Visualisation actions button is overlap on to the
bar chart (#145973)](#145973)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-23T09:27:58Z","message":"[Security
Solution] Visualisation actions button is overlap on to the bar chart
(#145973)\n\n## Summary\r\n\r\nOriginal issue: Visualisation actions
button is overlap on to the
bar\r\nchart.\r\nhttps://github.com//issues/128344\r\n\r\nBefore:\r\n<img
width=\"575\" alt=\"Screenshot 2022-11-22 at 11 31
19\"\r\nsrc=\"https://user-images.githubusercontent.com/6295984/203304147-ff0ec823-182c-40bf-8da5-fa45180eae0a.png\">\r\n\r\nAfter:\r\n<img
width=\"765\" alt=\"Screenshot 2022-11-22 at 11 30
39\"\r\nsrc=\"https://user-images.githubusercontent.com/6295984/203304150-5dae9a4a-341d-4717-abb1-f56aa20ba6bd.png\">","sha":"a0658669f29ed508c87b79d678f21695591fca89","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Explore","v8.6.0","v8.7.0"],"number":145973,"url":"https://github.com/elastic/kibana/pull/145973","mergeCommit":{"message":"[Security
Solution] Visualisation actions button is overlap on to the bar chart
(#145973)\n\n## Summary\r\n\r\nOriginal issue: Visualisation actions
button is overlap on to the
bar\r\nchart.\r\nhttps://github.com//issues/128344\r\n\r\nBefore:\r\n<img
width=\"575\" alt=\"Screenshot 2022-11-22 at 11 31
19\"\r\nsrc=\"https://user-images.githubusercontent.com/6295984/203304147-ff0ec823-182c-40bf-8da5-fa45180eae0a.png\">\r\n\r\nAfter:\r\n<img
width=\"765\" alt=\"Screenshot 2022-11-22 at 11 30
39\"\r\nsrc=\"https://user-images.githubusercontent.com/6295984/203304150-5dae9a4a-341d-4717-abb1-f56aa20ba6bd.png\">","sha":"a0658669f29ed508c87b79d678f21695591fca89"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145973","number":145973,"mergeCommit":{"message":"[Security
Solution] Visualisation actions button is overlap on to the bar chart
(#145973)\n\n## Summary\r\n\r\nOriginal issue: Visualisation actions
button is overlap on to the
bar\r\nchart.\r\nhttps://github.com//issues/128344\r\n\r\nBefore:\r\n<img
width=\"575\" alt=\"Screenshot 2022-11-22 at 11 31
19\"\r\nsrc=\"https://user-images.githubusercontent.com/6295984/203304147-ff0ec823-182c-40bf-8da5-fa45180eae0a.png\">\r\n\r\nAfter:\r\n<img
width=\"765\" alt=\"Screenshot 2022-11-22 at 11 30
39\"\r\nsrc=\"https://user-images.githubusercontent.com/6295984/203304150-5dae9a4a-341d-4717-abb1-f56aa20ba6bd.png\">","sha":"a0658669f29ed508c87b79d678f21695591fca89"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadoum machadoum machadoum approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience fixed release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibana-ci @kibanamachine @machadoum