Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fix dark theme issues with spy toggle and spy pane (#13345) #14448

Merged

Conversation

stacey-gammon
Copy link
Contributor

backports #13345

  • Fix dark theme issues with spy toggle and spy pane

  • Port dark theme portion of styling kuiIcon into uiFramework library

* Fix dark theme issues with spy toggle and spy pane

* Port dark theme portion of styling kuiIcon into uiFramework library
@stacey-gammon
Copy link
Contributor Author

Build failing but shouldn't have anythign to do with this PR:

18:32:26   1) es/healthCheck/ensureTypesExist() v6 index ignores extra types in index:
18:32:26      expected spy to be called 6 times but was called 5 times
18:32:26     spy(indices.get, { feature: "_mappings", index: "gek" }) => [Promise] {  } at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/src/core_plugins/elasticsearch/lib/ensure_types_exist.js:15:23
18:32:26     spy(indices.putMapping, {
18:32:26   body: { properties: { da: { type: "keyword" } } },
18:32:26   index: "gek",
18:32:26   type: "doc",
18:32:26   update_all_types: true
18:32:26 }) => [Promise] {  } at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/src/core_plugins/elasticsearch/lib/ensure_types_exist.js:51:13
18:32:26 
18:32:26     spy(indices.putMapping, {
18:32:26   body: { properties: { ecuboiha: { type: "integer" } } },
18:32:26   index: "gek",
18:32:26   type: "doc",
18:32:26   update_all_types: true
18:32:26 }) => [Promise] {  } at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/src/core_plugins/elasticsearch/lib/ensure_types_exist.js:51:13
18:32:26 
18:32:26     spy(indices.putMapping, {
18:32:26   body: { properties: { pabopok: { type: "integer" } } },
18:32:26   index: "gek",
18:32:26   type: "doc",
18:32:26   update_all_types: true
18:32:26 }) => [Promise] {  } at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/src/core_plugins/elasticsearch/lib/ensure_types_exist.js:51:13
18:32:26 
18:32:26     spy(indices.putMapping, {
18:32:26   body: { properties: { uco: { type: "boolean" } } },
18:32:26   index: "gek",
18:32:26   type: "doc",
18:32:26   update_all_types: true
18:32:26 }) => [Promise] {  } at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/src/core_plugins/elasticsearch/lib/ensure_types_exist.js:51:13
18:32:26   AssertError: expected spy to be called 6 times but was called 5 times
18:32:26       spy(indices.get, { feature: "_mappings", index: "gek" }) => [Promise] {  } at src/core_plugins/elasticsearch/lib/ensure_types_exist.js:15:23
18:32:26       spy(indices.putMapping, {
18:32:26     body: { properties: { da: { type: "keyword" } } },
18:32:26     index: "gek",
18:32:26     type: "doc",
18:32:26     update_all_types: true
18:32:26   }) => [Promise] {  } at src/core_plugins/elasticsearch/lib/ensure_types_exist.js:51:13
18:32:26   
18:32:26       spy(indices.putMapping, {
18:32:26     body: { properties: { ecuboiha: { type: "integer" } } },
18:32:26     index: "gek",
18:32:26     type: "doc",
18:32:26     update_all_types: true
18:32:26   }) => [Promise] {  } at src/core_plugins/elasticsearch/lib/ensure_types_exist.js:51:13
18:32:26   
18:32:26       spy(indices.putMapping, {
18:32:26     body: { properties: { pabopok: { type: "integer" } } },
18:32:26     index: "gek",
18:32:26     type: "doc",
18:32:26     update_all_types: true
18:32:26   }) => [Promise] {  } at src/core_plugins/elasticsearch/lib/ensure_types_exist.js:51:13
18:32:26   
18:32:26       spy(indices.putMapping, {
18:32:26     body: { properties: { uco: { type: "boolean" } } },
18:32:26     index: "gek",
18:32:26     type: "doc",
18:32:26     update_all_types: true
18:32:26   }) => [Promise] {  } at src/core_plugins/elasticsearch/lib/ensure_types_exist.js:51:13
18:32:26       at Object.fail (node_modules/sinon/lib/sinon/assert.js:90:29)
18:32:26       at failAssertion (node_modules/sinon/lib/sinon/assert.js:51:24)
18:32:26       at Object.assertCallCount [as callCount] (node_modules/sinon/lib/sinon/assert.js:131:21)
18:32:26       at Context.<anonymous> (src/core_plugins/elasticsearch/lib/__tests__/ensure_types_exist.js:210:20)
18:32:26       at undefined.next (native)
18:32:26       at step (src/core_plugins/elasticsearch/lib/__tests__/ensure_types_exist.js:6:1)
18:32:26       at src/core_plugins/elasticsearch/lib/__tests__/ensure_types_exist.js:6:1

jenkins, test this

@stacey-gammon stacey-gammon merged commit d546ff2 into elastic:5.6 Oct 13, 2017
@stacey-gammon stacey-gammon deleted the 5.6/fix/spy-toggle-dark-theme branch October 24, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant