-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed cardinality agg logic in action_status #144162
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
(cherry picked from commit 4c52d09)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Added |
Summary
Related to #144161
Changed logic in
action_status
API calculation of agent action acks, to only use cardinality agg if the doc count is less than the precision threshold (40k, this is the max value).Observed an issue locally that after successful add/remove tags, the ack count didn't reach 50k in
action_status
response, in this casedoc_count
was correct, 50k.So it looks like the cardinality agg can be lower or higher than the actual count.