Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip remote clusters test 138129 #143329

Merged
merged 21 commits into from
Oct 14, 2022

Conversation

cuff-links
Copy link
Contributor

@cuff-links cuff-links commented Oct 13, 2022

Closes #138129

Running this in flaky test runner to see if issue persists. #138510 was a fix that addressed the issue.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #50 / lens app - group 2 lens dashboard tests should be able to add filters by clicking in pie chart

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cuff-links
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1425 Ran this in flaky test runner 200 times.

@cuff-links cuff-links marked this pull request as ready for review October 14, 2022 00:06
@cuff-links cuff-links requested a review from LeeDr October 14, 2022 00:07
@cuff-links cuff-links added backport:prev-minor Backport to the previous minor version (i.e. one version back from main) v8.6.0 Feature:CCR and Remote Clusters Team:QA Team label for QA Team labels Oct 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cuff-links cuff-links merged commit 4229010 into elastic:main Oct 14, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2022
* Removed comment of the issue that was referenced for the skip. But the tests were already skipped.

* Unskipping test as a fix has been made. 138510

Co-authored-by: cuffs <cuffs@cuffss-Office-MacBook-Pro.local>
(cherry picked from commit 4229010)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 14, 2022
* Removed comment of the issue that was referenced for the skip. But the tests were already skipped.

* Unskipping test as a fix has been made. 138510

Co-authored-by: cuffs <cuffs@cuffss-Office-MacBook-Pro.local>
(cherry picked from commit 4229010)

Co-authored-by: John Dorlus <jsdorlus@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) Feature:CCR and Remote Clusters Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test_ui_functional test_xpack_functional v8.5.0 v8.6.0
Projects
None yet
5 participants