Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Renaming helper functions about transaction aggegations #143299

Merged
merged 7 commits into from
Oct 14, 2022
Merged

[APM] Renaming helper functions about transaction aggegations #143299

merged 7 commits into from
Oct 14, 2022

Conversation

kpatticha
Copy link
Contributor

Summary

Closes #141185

  • Rename helper functions
  • document service metrics document type

@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Oct 13, 2022
@kpatticha kpatticha requested a review from a team as a code owner October 13, 2022 15:55
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv reviewed Oct 14, 2022
View reviewed changes
x-pack/plugins/apm/dev_docs/apm_queries.md Outdated
"transaction": {
"duration.summary": {
"sum": 376492831,
"value_count": 775
Copy link
Member

@sorenlouv sorenlouv Oct 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should value_count and _doc_count be the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! my fault copy-paste issue, should update it

ref: https://github.com/elastic/apm-server/pull/9143/files

@kpatticha @sorenlouv
Update x-pack/plugins/apm/dev_docs/apm_queries.md
1ccddcc 
Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
sorenlouv
sorenlouv approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@kpatticha kpatticha enabled auto-merge (squash) October 14, 2022 11:26
@kpatticha kpatticha merged commit bf4f62e into elastic:main Oct 14, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 14, 2022
@kpatticha kpatticha mentioned this pull request Oct 14, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Service metrics - after merge improvements
5 participants
@kpatticha @elasticmachine @kibana-ci @sorenlouv @kibanamachine