Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Generate Service metrics with synthrace #141739

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Sep 26, 2022

Summary

closes #141024

The datastream is saved as metrics-apm.service-default and can be filtered with metricset.name: service

related to apm-server work

Document generated with synthrace
{
"took": 0,
"timed_out": false,
"_shards": {
  "total": 1,
  "successful": 1,
  "skipped": 0,
  "failed": 0
},
"hits": {
  "total": {
    "value": 109,
    "relation": "eq"
  },
  "max_score": 1,
  "hits": [
    {
      "_index": ".ds-metrics-apm.service-default-2022.09.26-000001",
      "_id": "C_4n-XFHbbdO6p13AAABg3jySm0",
      "_score": 1,
      "_source": {
        "_doc_count": 772,
        "@timestamp": "2022-09-26T08:38:08.237Z",
        "metricset": {
          "name": "service"
        },
        "processor": {
          "event": "metric"
        },
        "service": {
          "name": "web-go-0",
          "environment": "Synthtrace: low_throughput",
          "node": {}
        },
        "transaction": {
          "duration": {
            "summary": {
              "min": 0,
              "max": 3768887.2570648515,
              "sum": 170142852.20549336,
              "value_count": 772
            }
          },
          "failure_count": 116,
          "success_count": 598
        },
        "observer": {
          "type": "synthtrace",
          "version": "8.5.0",
          "version_major": 8
        },
        "ecs": {
          "version": "1.4"
        }
      }
    }
  ]
}
}

Try the changes locally

  1. simply run synthrace
    node scripts/synthtrace packages/kbn-apm-synthtrace/src/scenarios/low_throughput.ts --username elastic --local
  2. check the datastream metrics-apm.service-default

@kpatticha kpatticha requested a review from Mpdreamz September 26, 2022 08:48
@kpatticha kpatticha requested a review from a team as a code owner September 26, 2022 08:48
@kpatticha
Copy link
Contributor Author

@elasticmachine merge upstream

@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Sep 26, 2022
@kpatticha kpatticha force-pushed the service-metrics-synth branch from 87e954d to b460c80 Compare September 26, 2022 09:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for re-aligning this with the server's implementation

@kpatticha kpatticha merged commit cc9827e into elastic:main Sep 27, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthrace] Update service metric aggregator to match apm-server fields
5 participants