Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain Log Rate Spikes: Add tooltip for group columns and adjust copy to reflect groups in ot… #141687

Merged
merged 3 commits into from
Sep 26, 2022
Merged

[ML] Explain Log Rate Spikes: Add tooltip for group columns and adjust copy to reflect groups in ot… #141687

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cafcacb
Add tooltip for group columns and adjust copy to reflect groups in ot…
alvarezmelissa87 Sep 23, 2022
9dd9749
fix localization
alvarezmelissa87 Sep 23, 2022
480343d
Merge branch 'main' into ml-aiops-badge-copy
walterra Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions x-pack/plugins/aiops/public/components/spike_analysis_table/spike_analysis_table_groups.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,26 @@ export const SpikeAnalysisGroupsTable: FC<SpikeAnalysisTableProps> = ({
{
'data-test-subj': 'aiopsSpikeAnalysisGroupsTableColumnGroup',
field: 'group',
name: i18n.translate('xpack.aiops.explainLogRateSpikes.spikeAnalysisTableGroups.groupLabel', {
defaultMessage: 'Group',
}),
name: (
<EuiToolTip
position="top"
content={i18n.translate(
'xpack.aiops.explainLogRateSpikes.spikeAnalysisTableGroups.groupColumnTooltip',
{
defaultMessage:
'Displays field values unique to the group. Expand row to see all values.',
}
)}
>
<>
<FormattedMessage
id="xpack.aiops.explainLogRateSpikes.spikeAnalysisTableGroups.groupLabel"
defaultMessage="Group"
/>
<EuiIcon size="s" color="subdued" type="questionInCircle" className="eui-alignTop" />
</>
</EuiToolTip>
),
render: (_, { group, repeatedValues }) => {
const valuesBadges = [];
for (const fieldName in group) {
Expand Down Expand Up @@ -292,7 +309,7 @@ export const SpikeAnalysisGroupsTable: FC<SpikeAnalysisTableProps> = ({
'xpack.aiops.explainLogRateSpikes.spikeAnalysisTableGroups.logRateColumnTooltip',
{
defaultMessage:
'A visual representation of the impact of the field on the message rate difference',
'A visual representation of the impact of the group on the message rate difference',
}
)}
>
Expand Down Expand Up @@ -366,9 +383,9 @@ export const SpikeAnalysisGroupsTable: FC<SpikeAnalysisTableProps> = ({
<EuiToolTip
position="top"
content={i18n.translate(
'xpack.aiops.explainLogRateSpikes.spikeAnalysisTable.impactLabelColumnTooltip',
'xpack.aiops.explainLogRateSpikes.spikeAnalysisTableGroups.impactLabelColumnTooltip',
{
defaultMessage: 'The level of impact of the field on the message rate difference',
defaultMessage: 'The level of impact of the group on the message rate difference',
}
)}
>
Expand Down