[Maps] unskip 'embed in dashboard' functional test #141289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
commented
Sep 21, 2022
| await filterBar.selectIndexPattern('meta_for_geo_shapes*'); | ||
| await filterBar.addFilter('shape_name', 'is', 'alpha'); // runtime fields do not have autocomplete | ||
| }); | ||
| await filterBar.addFilterAndSelectDataView('meta_for_geo_shapes*', 'shape_name', 'is', 'alpha'); |
There was a problem hiding this comment.
Able to remove retry because search bar redesign has moved add filter button so its no longer next to newly created filter pills.
…-ref HEAD~1..HEAD --fix'
|
@elasticmachine merge upstream |
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Sep 23, 2022
* [Maps] unskip 'embed in dashboard' functional test * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Peihl <nick.peihl@elastic.co> (cherry picked from commit d23aa31)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2022
* [Maps] unskip 'embed in dashboard' functional test * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Peihl <nick.peihl@elastic.co> (cherry picked from commit d23aa31) Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
sophiec20
added
Feature:Maps
and removed
[Deprecated-Use Team:Presentation]Team:Geo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140241
Test was flaky because setting index pattern and adding the filter were broken into 2 separate calls. This PR combines setting index pattern and creating filter into a single call to avoid flaky interactions with opening/closing add filter popover.
flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1282