[APM] Use _doc_count from service metrics
#141210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:APM) |
|
@dgieselaar what's best release label, can I still add it as part of 8.5? |
2 tasks
kpatticha
added
release_note:skip
sorenlouv
reviewed
Sep 21, 2022
.../plugins/apm/server/routes/services/get_services/get_service_aggregated_transaction_stats.ts
Show resolved
Hide resolved
dgieselaar
reviewed
Sep 21, 2022
...s/get_services_detailed_statistics/get_service_aggregated_transaction_detailed_statistics.ts
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kpatticha
changed the title
_doc_count from transaction metrics_doc_count from service metrics
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 22, 2022
* [APM] Use `_doc_count` from transaction metrics * Remove unnecessary agg (cherry picked from commit 926fd12)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 22, 2022
* [APM] Use `_doc_count` from transaction metrics * Remove unnecessary agg (cherry picked from commit 926fd12) Co-authored-by: Katerina Patticha <aikaterini.patticha@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: #141185
elastic/apm-server#9143
apm-server added the
_doc_countto ensure proper bucket counts and avoid the aggregation on value count.