Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slo): use spaceId for pipeline names #141133

Merged
merged 4 commits into from
Sep 20, 2022
Merged

fix(slo): use spaceId for pipeline names #141133

merged 4 commits into from
Sep 20, 2022

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Sep 20, 2022 •
edited
Loading

📝 Summary

Fixes #141154

This PR fixes an issue with the ingest pipeline naming to use the spaceId: slo-observability.sli.monthly-{spaceId}

I've also fixed the 204 No Content as suggested by @fkanout in a previous PR

Screenshot
image

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0 labels Sep 20, 2022
@kdelemme kdelemme self-assigned this Sep 20, 2022
@kdelemme kdelemme requested review from fkanout and a team September 20, 2022 16:01
@kdelemme kdelemme marked this pull request as ready for review September 20, 2022 16:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

simianhacker
simianhacker approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme kdelemme enabled auto-merge (squash) September 20, 2022 19:05
@kdelemme kdelemme merged commit ab0e2fb into elastic:main Sep 20, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / banners - functional tests per-spaces banners "after all" hook for "displays the global banner on the login page"
  • [job] [logs] FTR Configs #2 / banners - functional tests per-spaces banners "before all" hook for "displays the space-specific banner within the space"

Metrics [docs]

✅ unchanged

History

  • 💚 Build #74056 succeeded 44b640df3addca9540e56101dc49d48c3174f355

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2022
@kdelemme kdelemme deleted the fix/slo-resources-management branch September 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

@fkanout fkanout Awaiting requested review from fkanout

Assignees

@kdelemme kdelemme

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Actionable Observability] Fix SLO ingest pipeline name
5 participants
@kdelemme @elasticmachine @kibana-ci @simianhacker @kibanamachine