Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain Log Rate Spikes: Add link to Discover to grouped results table. #141071

Merged
merged 5 commits into from
Sep 20, 2022
Merged

[ML] Explain Log Rate Spikes: Add link to Discover to grouped results table. #141071

merged 5 commits into from
Sep 20, 2022

Conversation

walterra
Copy link
Contributor

Summary

Part of #138117.

Adds link to Discover to grouped results table.

Review note: This copies code from the non-grouped table version, we'll consolidate shared code in a follow-up.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis labels Sep 20, 2022
@walterra walterra requested a review from a team as a code owner September 20, 2022 12:31
@walterra walterra self-assigned this Sep 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87
alvarezmelissa87 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 756.3KB 759.0KB +2.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 841b930 into elastic:main Sep 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2022
@walterra walterra deleted the ml-aiops-grouping-discover-link branch September 20, 2022 20:46
@walterra walterra mentioned this pull request Sep 21, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @kibana-ci @alvarezmelissa87 @kibanamachine