Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] add padding to page template #140977

Merged
merged 1 commit into from
Sep 20, 2022
Merged

[Stack Monitoring] add padding to page template #140977

merged 1 commit into from
Sep 20, 2022

Conversation

klacabane
Copy link
Contributor

Summary

Closes #140908

Padding was gone from stack monitoring page template, most likely caused by eui upgrade.

Testing

  • load stack monitoring and enable internal monitoring
  • navigate to available elasticsearch/kibana views and notice the perfectly padded content in the grey area

Screenshot 2022-09-19 at 18 24 02

@klacabane klacabane added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services >bug v8.5.0 labels Sep 19, 2022
@klacabane klacabane self-assigned this Sep 19, 2022
@klacabane klacabane requested a review from a team as a code owner September 19, 2022 16:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@klacabane klacabane added the release_note:skip Skip the PR/issue when compiling release notes label Sep 19, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 479.7KB 479.7KB +77.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @klacabane

@klacabane klacabane merged commit 2acc1c8 into elastic:main Sep 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2022
@rudolf rudolf added bug Fixes for quality problems that affect the customer experience and removed >bug labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees

@klacabane klacabane

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] missing padding in page container
6 participants
@klacabane @elasticmachine @kibana-ci @miltonhultgren @rudolf @kibanamachine