Remove unnecessary time units in ILM policy dialog

[Dosant]

Summary

Fix #137081

Please remove unnecessary time units (less than minutes) in the Index Lifecycle Policy creation dialog. There is no use case for these rollover periods and they are potentially harmful when selected by accident.

Also cleans up separate units used in downsample action #138748 (comment)

This cleans up smaller units from the following inputs:

• If users used no longer supported units, when they open the form, their old unit is displayed.
• these inputs support only integers. so it is no longer possible to configure e.g 1.5 minutes intervals using 90 seconds in the input. (I guess this is OK)

[Dosant]

@elasticmachine merge upstream

[Dosant]

@elasticmachine merge upstream

[alisonelizabeth]

Thanks for cleaning this up @Dosant!

I was testing locally and noticed if I create a policy with unsupported time units, the unit shows in the dropdown for the min age, but not the rollover max age. Is that expected?

// ms value, but does not show in dropdown

// s value and shows in the dropdown

Also, I noticed on large screens this input field is not aligned with the rest. I don't think this is related to your PR, but just pointing out. I can open up an issue if there isn't one already.

[Dosant]

I was testing locally and noticed if I create a policy with unsupported time units, the unit shows in the dropdown for the min age, but not the rollover max age. Is that expected?

Yes. We have these very similar controls implemented in two very different ways. I went with the simplest approach to "fallback" in each implementation.
I would prefer the simpler approach, like in rollover max-age, then the one in min-age, but I couldn't do it in min-age because it uses a select component from EUI, and it expects all the options in the dropdown array.

Would you suggest changing the current behavior somehow?

Also, I noticed on large screens this input field is not aligned with the rest. I don't think this is related to your PR, but just pointing out. I can open up an issue if there isn't one already.

Not sure if the issue exists.
Agree that this or my recent prs didn't cause this

[alisonelizabeth]

Thanks for the explanation @Dosant! I'm happy with these changes 👍

[Dosant]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 9a6d26d

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
indexLifecycleManagement	158.7KB	157.6KB	-1.1KB

History

• 💚 Build #73281 succeeded 532bd59
• 💚 Build #72777 succeeded 704ccce
• 💔 Build #72698 failed f81216f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream