Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Cloud reads deployment metadata from config #140591

Closed
wants to merge 1 commit into from

Conversation

afharo
Copy link
Member

@afharo afharo commented Sep 13, 2022

Summary

This is a Proof of concept to test how ESS Metadata could be provided to the cloud plugin via optional config parameters.

The configuration entries would look like below

xpack.cloud.id: "{Cloud ID}"

xpack.cloud.metadata.is_elastic_staff_owned: false
xpack.cloud.metadata.in_trial: true

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 13, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #3 / apis Telemetry /api/telemetry/v2/clusters/_stats monitoring/multicluster should pass the schema validations
  • [job] [logs] FTR Configs #3 / apis Telemetry /api/telemetry/v2/clusters/_stats monitoring/multicluster should pass the schema validations
  • [job] [logs] FTR Configs #36 / core plugins rendering service exposes plugin config settings to authenticated users
  • [job] [logs] FTR Configs #36 / core plugins rendering service exposes plugin config settings to authenticated users
  • [job] [logs] Jest Tests #1 / createCloudUsageCollector Fetched Usage data return isCloudEnabled boolean
  • [job] [logs] Jest Tests #1 / registerCloudDeploymentIdAnalyticsContext it registers the context provider and emits the cloudId

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloud 11.3KB 11.6KB +244.0B
Unknown metric groups

API count

id before after diff
cloud 29 30 +1

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 7 6 -1
total -2

ESLint disabled line counts

id before after diff
apm 80 78 -2
observability 45 44 -1
synthetics 59 53 -6
ux 10 9 -1
total -10

Total ESLint disabled count

id before after diff
apm 94 91 -3
observability 52 50 -2
synthetics 65 59 -6
ux 13 12 -1
total -12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo
Copy link
Member Author

afharo commented Oct 13, 2022

Closing in favour of #143002

@afharo afharo closed this Oct 13, 2022
@afharo afharo deleted the poc-cloud-metadata-via-config branch October 13, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants