Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out error docs from standalone cluster lists #140102

Merged

Conversation

matschaffer
Copy link
Contributor

@matschaffer matschaffer commented Sep 6, 2022

Summary

Ensures error docs won't lead to erroneous "Standalone cluster" entries.

Fixes elastic/integrations#4011

Requires #137904 and elastic/integrations#4147 to test functionality.

Keeping as draft until those are merged so we can test properly. All merged, just make sure you have main kibana & packages.

Testing

(Details WIP)

  • Set up elastic-package stack with a logstash profile
  • Make sure that profile has a bad hostname (to make sure you get error docs)
  • Ensure no "Standalone Cluster" is present in Stack Monitoring UI

@matschaffer matschaffer added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Sep 6, 2022
@matschaffer matschaffer self-assigned this Sep 6, 2022
@klacabane
Copy link
Contributor

@matschaffer this is the right fix but we also need the error.message field mapped. I'll send a PR

standaloneClusterFilter already had this covered, but the field wasn't mapped initially.
@matschaffer matschaffer changed the title Attempt: Filter out error docs from standalone cluster lists Filter out error docs from standalone cluster lists Sep 7, 2022
@matschaffer matschaffer marked this pull request as ready for review September 9, 2022 03:15
@matschaffer matschaffer requested a review from a team as a code owner September 9, 2022 03:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@matschaffer
Copy link
Contributor Author

@elasticmachine merge upstream

@matschaffer
Copy link
Contributor Author

Marking this ready for review, but admittedly the testing story is pretty thin. I'll try to work on a cleaner flow today.

In the mean time I'm pretty sure @klacabane and @crespocarlos have a sufficient level of elastic-package tribal knowledge to know to validate the change.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

@klacabane klacabane added release_note:skip Skip the PR/issue when compiling release notes v8.5.0 labels Sep 9, 2022
@matschaffer matschaffer merged commit f84444d into elastic:main Sep 9, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 9, 2022
@matschaffer matschaffer deleted the integrations-4011-standalone-errors branch September 9, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Support for error documents
5 participants