[ML] Explain Log Rate Spikes: Histogram fixes. #139933
Conversation
walterra
added
release_note:fix
:ml
v8.5.0
Feature:ML/AIOps
| // temporary fix to reduce horizontal chart margin until fixed in Elastic Charts itself | ||
| labelFormat={() => ''} | ||
| timeAxisLayerCount={useLegacyTimeAxis ? 0 : 2} | ||
| style={useLegacyTimeAxis ? {} : MULTILAYER_TIME_AXIS_STYLE} |
There was a problem hiding this comment.
This workaround works only with the multilayer time axis and not with the legacy.
So my suggestion is to remove completely the legacyTimeAxis configuration and use only the multilayer one.
If you prefer keep that, you instead should change the labelFormat as:
labelFormat={useLegacyTimeAxis ? undefined : () => ''}you can double check how it will work by setting the legacy time axis in the Advanced setting
There was a problem hiding this comment.
Thanks for the hint! I'll stick with useLegacyTimeAxis for now so the chart behavior is the same as in Discover.
walterra
added
the
bug
|
Pinging @elastic/ml-ui (:ml) |
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
LGTM.
Not related to the changes here, as happens before too, but when comparing to the doc count in Discover I noticed that the behavior for the first and last buckets is different here, where you see empty buckets, compared to populated buckets in the Discover chart.
Log rate spikes:
Compared to Discover (same time range):
|
@peteharverson Thanks for pointing out the empty buckets, fixed them as part of this PR in 2b81837. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
Fixes histogram styling, some alignments with discover chart. - Switch BarSeries to HistogramBarSeries. - Fix too generic IDs. - Align y axis ticks settings with Discover chart. - Fixes horizontal margins. - Fixes x domain to avoid empty buckets at start and end of histogram. (cherry picked from commit 1ff209a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Fixes histogram styling, some alignments with discover chart. - Switch BarSeries to HistogramBarSeries. - Fix too generic IDs. - Align y axis ticks settings with Discover chart. - Fixes horizontal margins. - Fixes x domain to avoid empty buckets at start and end of histogram. (cherry picked from commit 1ff209a) Co-authored-by: Walter Rafelsberger <walter@elastic.co>
Summary
Fixes histogram styling, some alignments with discover chart.
BarSeriestoHistogramBarSeries.Previous:
After:
Checklist